Page MenuHomeVyOS Platform
Create Task
Maniphest T7472

IPoE: Add stricter validation for giaddr if dhcp-relay is configured
Closed, ResolvedPublic
Actions

Description

From accel-ppp documentation

The relay=x.x.x.x parameter specifies DHCPv4 relay IP address to pass requests to. If specified giaddr is also needed.

So we need to add check for giaddr if dhcp-relay is defined

Details

Version
-
Is it a breaking change?
Stricter validation
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

natali-rs1985 created this task.May 21 2025, 7:46 AM
natali-rs1985 changed the task status from Open to In progress.
natali-rs1985 added a comment.May 21 2025, 8:02 AM

https://github.com/vyos/vyos-1x/pull/4521

pasik subscribed.May 21 2025, 8:42 AM
natali-rs1985 added a comment.May 21 2025, 12:53 PM

add a warning for 1.4 https://github.com/VyOS-Networks/vyos-1x/pull/722

natali-rs1985 added projects: VyOS 1.5 Circinus, VyOS 1.4 Sagitta (1.4.3).May 21 2025, 12:54 PM
natali-rs1985 mentioned this in rVYOSONEXe12ac5497091: ipoe_server: T7472: Add validation for giaddr if dhcp-relay is defined.May 21 2025, 2:46 PM
Restricted Repository Identity mentioned this in rVYOSONEXbc6e337a13f3: Merge pull request #4521 from natali-rs1985/T7472.May 21 2025, 2:46 PM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Stricter validation.May 21 2025, 3:47 PM
dmbaturin changed Issue type from Unspecified (please specify) to Bug (incorrect behavior).
natali-rs1985 closed this task as Resolved.May 23 2025, 11:14 AM
natali-rs1985 moved this task from Need Triage to Completed on the VyOS Rolling board.
natali-rs1985 moved this task from Open to Finished on the VyOS 1.5 Circinus board.
natali-rs1985 moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.3) board.
dmbaturin edited projects, added VyOS 1.5 Circinus (1.5-stream-2025-Q2); removed VyOS 1.5 Circinus.Jul 9 2025, 12:47 PM
dmbaturin mentioned this in 1.4.3.Jul 17 2025, 8:18 AM