Page MenuHomeVyOS Platform

Remove unnecessary uses of string start and end markers in validation regexes
Closed, ResolvedPublic

Description

validate_value implicitly wraps all regexes in ^...$ to save the user the trouble.

However, we do have command definitions where that was done by hand, by someone unaware of the fact that it's not required.

$ grep -r '<regex>^' interface-definitions/ | grep '-'
interface-definitions/policy.xml.in:                        <regex>^[+|-]?rtt$</regex>
interface-definitions/load-balancing_haproxy.xml.in:                        <regex>^\/([^?#\s]*)(\?[^#\s]*)?$</regex>
interface-definitions/include/firewall/geoip.xml.i:          <regex>^(ad|ae|af|ag|ai|al|am|ao|aq|ar|as|at|au|aw|ax|az|ba|bb|bd|be|bf|bg|bh|bi|bj|bl|bm|bn|bo|bq|br|bs|bt|bv|bw|by|bz|ca|cc|cd|cf|cg|ch|ci|ck|cl|cm|cn|co|cr|cu|cv|cw|cx|cy|cz|de|dj|dk|dm|do|dz|ec|ee|eg|eh|er|es|et|fi|fj|fk|fm|fo|fr|ga|gb|gd|ge|gf|gg|gh|gi|gl|gm|gn|gp|gq|gr|gs|gt|gu|gw|gy|hk|hm|hn|hr|ht|hu|id|ie|il|im|in|io|iq|ir|is|it|je|jm|jo|jp|ke|kg|kh|ki|km|kn|kp|kr|kw|ky|kz|la|lb|lc|li|lk|lr|ls|lt|lu|lv|ly|ma|mc|md|me|mf|mg|mh|mk|ml|mm|mn|mo|mp|mq|mr|ms|mt|mu|mv|mw|mx|my|mz|na|nc|ne|nf|ng|ni|nl|no|np|nr|nu|nz|om|pa|pe|pf|pg|ph|pk|pl|pm|pn|pr|ps|pt|pw|py|qa|re|ro|rs|ru|rw|sa|sb|sc|sd|se|sg|sh|si|sj|sk|sl|sm|sn|so|sr|ss|st|sv|sx|sy|sz|tc|td|tf|tg|th|tj|tk|tl|tm|tn|to|tr|tt|tv|tw|tz|ua|ug|um|us|uy|uz|va|vc|ve|vg|vi|vn|vu|wf|ws|ye|yt|za|zm|zw)$</regex>
interface-definitions/include/haproxy/rule-backend.xml.i:              <regex>^\/[\w\-.\/]+$</regex>
interface-definitions/include/haproxy/rule-backend.xml.i:              <regex>^\/[\w\-.\/]+$</regex>
interface-definitions/include/haproxy/rule-backend.xml.i:              <regex>^\/[\w\-.\/]+$</regex>
interface-definitions/include/haproxy/rule-backend.xml.i:              <regex>^\/[\w\-.\/]*$</regex>
interface-definitions/include/haproxy/rule-frontend.xml.i:              <regex>^\/[\w\-.\/]+$</regex>
interface-definitions/include/haproxy/rule-frontend.xml.i:              <regex>^\/[\w\-.\/]+$</regex>
interface-definitions/include/haproxy/rule-frontend.xml.i:              <regex>^\/[\w\-.\/]+$</regex>
interface-definitions/include/haproxy/rule-frontend.xml.i:              <regex>^\/[\w\-.\/]+$</regex>

We should remove those.

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)