Page MenuHomeVyOS Platform

Pass credentials to download commands in environment variables
Closed, ResolvedPublic

Description

At the moment, we pass usernames and passwords in inline environment variables embedded in shell commands, like in https://github.com/vyos/vyos-1x/blob/current/src/op_mode/image_installer.py#L576

That approach has some security implications. Since credentials are a part of the command, they are visible in the process list, and can potentially leak into tech supports reports and the like when the stars are right those files are generated exactly at the moment when a download script is running. Not very likely, but not impossible.

Passing them in process environment variables is much safer in that regard.

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Event Timeline

dmbaturin triaged this task as Normal priority.
Viacheslav moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.4) board.
Viacheslav moved this task from Need Triage to Completed on the VyOS Rolling board.