Page MenuHomeVyOS Platform
Create Task
Maniphest T7322

Addition and deletion of allowed-vlans on a bridge member is slow
Closed, ResolvedPublic
Actions

Description

Ranges that are configured in allowed-vlans (e.g. 1-4094), are deconstructed into all of their individual VLANs, which is unnecessary for the execution of these:
bridge vlan add dev {interface} vid {vlan} master
bridge vlan del dev {interface} vid {vlan} master

This leads to a very long commit time when doing large ranges.

Example:
Execution time of allowed-vlans 1-4094 in current state: 38.94 seconds

Execution time of allowed-vlans 1-4094 without unnecessary deconstruction of range: 4.94 seconds

Details

Version
1.4, 1.5
Is it a breaking change?
Perfectly compatible
Issue type
Performance optimization

Related Objects

Event Timeline

L0crian created this task.Apr 5 2025, 6:09 AM
L0crian created this object in space S1 VyOS Public.
L0crian added a comment.Apr 10 2025, 7:11 PM

PR: https://github.com/vyos/vyos-1x/pull/4444

pasik subscribed.Apr 10 2025, 7:22 PM
L0crian mentioned this in rVYOSONEXad5f14c783c1: bridge:T7322: Fix bridge allowed-vlan handling.Apr 22 2025, 2:50 PM
L0crian mentioned this in rVYOSONEX1d636f4c3779: bridge:T7322: Fix bridge allowed-vlan handling.
Restricted Repository Identity mentioned this in rVYOSONEXbe0ce3a33d71: Merge pull request #4444 from l0crian1/T7322-fix-allowed-vlan.Apr 22 2025, 2:50 PM
dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.3), VyOS 1.5 Circinus; removed VyOS 1.4 Sagitta.Apr 29 2025, 4:37 PM
dmbaturin renamed this task from Bridge: Addition/Deletion of allowed-vlans on bridge member is slow to Addition and deletion of allowed-vlans on a bridge member is slow.Jul 9 2025, 12:22 PM
dmbaturin closed this task as Resolved.
dmbaturin edited projects, added VyOS 1.5 Circinus (1.5-stream-2025-Q2); removed VyOS 1.5 Circinus.
dmbaturin mentioned this in 1.4.3.Jul 17 2025, 8:18 AM
L0crian added a subscriber: dmbaturin.Aug 5 2025, 5:37 PM

@dmbaturin

I just noticed this was mentioned as being added to 1.4.3 in the release notes:

Other resolved issues

Addition and deletion of allowed-vlans on a bridge member is slow (T7322).

But it doesn't appear to have actually made it into 1.4.3. Was it supposed to be in 1.4.3?

dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.4); removed VyOS 1.4 Sagitta (1.4.3).Aug 7 2025, 2:27 PM
c-po reopened this task as Needs testing.Aug 9 2025, 7:24 AM
c-po subscribed.

Re-opened for 1.4.4 backport

Viacheslav moved this task from Open to Finished on the VyOS 1.5 Circinus (1.5-stream-2025-Q2) board.Sep 25 2025, 1:35 AM
dmbaturin removed a project: VyOS 1.4 Sagitta (1.4.4).Wed, Nov 19, 2:22 PM
dmbaturin edited projects, added VyOS 1.4 Sagitta (1.4.4); removed VyOS Rolling.Mon, Dec 8, 3:55 PM
dmbaturin closed this task as Resolved.Mon, Dec 8, 6:28 PM
o.kuchmystyi subscribed.Tue, Dec 9, 10:16 AM

I have tested the latest internal build of sagitta and the next version 1.4.4 will contain this fix.