Page MenuHomeVyOS Platform
Create Task
Maniphest T7286

Add CLI to disable LDP establish hello packets
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Summary

Add CLI to disable LDP establish hello packets

Use case

Disable unnecessary LDP packets

Additional information

This feature was implemented in https://vyos.dev/T7226 and exists in the patch https://github.com/vyos/vyos-build/blob/current/scripts/package-build/frr/patches/frr/0001-ldpd-Option-for-disabled-LDP-hello-message-during-TC.patch for the current

VyOS# configure
VyOS(config)# mpls ldp
VyOS(config-ldp)# address-family ipv4
VyOS(config-ldp-af)# interface eth0
VyOS(config-ldp-af-if)# disable-establish-hello

In FRR, we see strange behavior. If a router has not formed an LDP neighbor adjacency yet, it answers all received LDP Hello packets from non-neighbors with new Hello packets.

Proposed CLI

set protocols mpls ldp interface eth0 disable-establish-hello

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Feature (new functionality)
Story points
3

Related Objects

Event Timeline

Viacheslav created this task.Wed, Mar 26, 8:44 AM
Viacheslav claimed this task.
Viacheslav triaged this task as Normal priority.
Viacheslav updated the task description. (Show Details)Wed, Mar 26, 8:46 AM
pasik subscribed.Wed, Mar 26, 9:30 AM
Viacheslav added a comment.EditedWed, Mar 26, 10:25 AM

PR https://github.com/vyos/vyos-1x/pull/4416

set protocols mpls ldp discovery transport-ipv4-address '192.0.2.111'
set protocols mpls ldp interface eth1 disable-establish-hello
set protocols mpls ldp interface eth2 disable-establish-hello
set protocols mpls ldp interface eth3
set protocols mpls ldp router-id '192.0.2.111'
commit

FRR config:

vyos@r14# vtysh -c "show run ldpd"
Building configuration...

Current configuration:
!
frr version 10.2.2
frr defaults traditional
hostname r14
service integrated-vtysh-config
!
mpls ldp
 router-id 192.0.2.111
 !
 address-family ipv4
  discovery transport-address 192.0.2.111
  label local allocate host-routes
  !
  interface eth1
   disable-establish-hello
  exit
  !
  interface eth2
   disable-establish-hello
  exit
  !
  interface eth3
  exit
  !
 exit-address-family
 !
exit
!
end
[edit]
vyos@r14#
Viacheslav changed the task status from Open to In progress.Wed, Mar 26, 10:25 AM
Viacheslav mentioned this in T7226: LDP Hello packets are generated to answer incoming Hello before forming neighbor adjacency.
Viacheslav mentioned this in rVYOSONEXc11daec3b06a: T7286: Add CLI option to disable LDP establish packets.Sat, Mar 29, 10:21 AM
Restricted Repository Identity mentioned this in rVYOSONEX55abc8214574: Merge pull request #4416 from sever-sever/T7286.Sat, Mar 29, 10:21 AM
Viacheslav added projects: VyOS 1.5 Circinus, VyOS 1.4 Sagitta (1.4.3).Sat, Mar 29, 11:20 AM
Viacheslav closed this task as Resolved.Tue, Apr 1, 3:19 PM
Viacheslav edited projects, added VyOS 1.4 Sagitta (1.4.2); removed VyOS 1.4 Sagitta (1.4.3).
Viacheslav moved this task from Open to Finished on the VyOS 1.5 Circinus board.
Viacheslav moved this task from Need Triage to Completed on the VyOS Rolling board.
Viacheslav moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.2) board.