Page MenuHomeVyOS Platform

_in_target doesn't check for None
Closed, WontfixPublicBUG

Description

all 3 _in_target function definitions don't check for None value. This makes it impossible to delete a group description:

On a testing VyOS:

configure
delete firewall
set firewall name test description test
commit

I expect the description to be deleted when I run this Ansible task:

- name: Delete description
  vyos.vyos.vyos_firewall_global:
    config:
      group:
        address_group:
        - name: test
      state: replaced

But nothing happens.

Because the function is defined in 3 locations, including in the utils, I will also swap the other 2 to the utils function.

GitHub PR: https://github.com/vyos/vyos.vyos/pull/405

Details

Version
6.0.0
Is it a breaking change?
Behavior change
Issue type
Bug (incorrect behavior)

Event Timeline

RubenNL changed the task status from Open to In progress.Thu, Mar 20, 10:39 AM
RubenNL triaged this task as Normal priority.

Decided to not replace the functionality for all methods, only where I found a problem. This means the information in this issue isn't relevant. I'll make a new issue to fix the test case above.