Page MenuHomeVyOS Platform

Remove unintended binary files from ipaddrcheck source tree and keep them from re-appearing
Closed, ResolvedPublic

Description

A build artifact was accidentally committed to ipaddrcheck (https://github.com/vyos/ipaddrcheck/blob/current/src/ipaddrcheck_functions.o) — due to my double negligence: I didn't add a proper .gitignore to it from the start and didn't notice a .o file in git status before committing.

That was the cause of floating CI failures after the fix for T6744: the fix does work, but when a compiled object file is present, recursive make may assume that it doesn't need to be built, so an outdated code ends up in the binary, instead of the fixed code in ipaddrcheck_functions.c

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

dmbaturin triaged this task as High priority.
dmbaturin renamed this task from Remove unintended binary files from ipaddrcheck source tree and keep them from appearing to Remove unintended binary files from ipaddrcheck source tree and keep them from re-appearing.Wed, Mar 12, 5:49 PM
dmbaturin closed this task as Resolved.
dmbaturin moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.2) board.
dmbaturin moved this task from Open to Finished on the VyOS 1.5 Circinus board.
dmbaturin moved this task from Need Triage to Completed on the VyOS Rolling board.