Page MenuHomeVyOS Platform

lldp: disable individual interface has no effect if 'all' is defined
Closed, ResolvedPublicBUG

Description

Enabling LLDP on all interface except one or more individual interfaces are set to disable has no effect.

To reproduce use:

set service lldp interface all
set service lldp interface eth0 disable

One might assume that LLDP is used in rx/tx mode on all interface but not on eth0. This is not true as LLDP is not explicitly disabled in the configuration, it rather is "just skipped"
https://github.com/vyos/vyos-1x/blob/c3f688653511881a2270d83cd0f098b45bfa7148/data/templates/lldp/vyos.conf.j2#L7

This bug has no effect on upcoming VyOS 1.5 and current branch after the implementation of T7165 which fixes this, too.

This task only addresses the bug for VyOS 1.4.x

Details

Version
1.4.0
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

c-po changed the task status from Open to In progress.
c-po claimed this task.
c-po triaged this task as Low priority.
c-po moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.2) board.