Page MenuHomeVyOS Platform
Create Task
Maniphest T7103

vyos-nightly-build workflow incorrect release info from vyos-1x and vyos-build
Closed, ResolvedPublicBUG
Actions

Description

it seems that for a while either none or the same list of commits keep being added to release info on the nightly builds (https://github.com/vyos/vyos-nightly-build/releases). bit of a shame since it was a nice place to keep track of what was in which nightly build.

I have quickly looked over the workflow and ran it in a fork for as far as I could (fails on lack of secrets) but the PREVIOUS_SUCCESS_BUILD_TIMESTAMP seems to be correct, as do the usage of it later on to get the new commits on both vyos-1x and vyos-build. I cant see any reason for it not working without being able to look in the full logs of the workflow running, hopefully someone can.

Details

Version
predates release history of rolling I can see
Is it a breaking change?
Perfectly compatible
Issue type
Infrastructure issue or change

Event Timeline

Ckath created this task.Jan 28 2025, 8:05 PM
Ckath edited projects, added GitHub Infrastructure; removed VyOS Rolling.Jan 28 2025, 8:10 PM
Ckath changed Version from 1.5-rolling-202501280006 to predates release history of rolling I can see.
pasik subscribed.Jan 28 2025, 8:11 PM
Ckath added a comment.EditedJan 28 2025, 9:27 PM

it seems I can look into the full workflow logs, but the root cause remains unclear to me.

when changelog is empty, there is nothing, so far so good. but notice it sets the fromTag here correctly.

Run mikepenz/[email protected]
  with:
    owner: vyos
    repo: vyos-1x
    fetchReviewers: false
    fromTag: e588ac20f67735c5fa924c94783b636de4378618
    toTag: HEAD
...
🚀 Load pull requests
  ℹ️ Comparing vyos/vyos-1x - 'e588ac20f67735c5fa924c94783b636de4378618...HEAD'
  ℹ️ Found 0 commits from the GitHub API for vyos/vyos-1x

(https://github.com/vyos/vyos-nightly-build/actions/runs/13000781801/job/36262555238)

at times it adds everything, it doesnt seem to (correctly) add the fromTag when going into release-changelog-builder-action. which causes it to try everything and get limited to some huge number still.

Run mikepenz/[email protected]
  with:
    owner: vyos
    repo: vyos-1x
    fetchReviewers: false
    toTag: HEAD
...
🚀 Load pull requests
  ℹ️ Comparing vyos/vyos-1x - '1.4.0...HEAD'
  ℹ️ Found 2540 commits from the GitHub API for vyos/vyos-1x
  ⚠️ Adjusted 'fromDate' to go max 365 back
  ℹ️ Fetching PRs between dates 2024-01-25T18:21:08.000Z to 2025-01-24T18:21:08.000Z for vyos/vyos-1x
  ℹ️ Retrieved 2540 release commits for vyos/vyos-1x
  Warning: ⚠️ Reached 'maxPullRequests' count 200 (1)
  ℹ️ Retrieved 276 PRs for vyos/vyos-1x in date range from API
  ℹ️ Retrieved 198 merged PRs for vyos/vyos-1x

(https://github.com/vyos/vyos-nightly-build/actions/runs/12969552330/job/36175630253)

I still dont understand how it does not manage to get a valid commit hash here, since the commands it claims to run work locally.

 cd vyos-build
echo "CHANGELOG_COMMIT_VYOS_BUILD=$(git log --since "2025-01-25T00:06:56Z" --format="%H" --reverse | head -n1)" >> $GITHUB_OUTPUT
cd ../vyos-1x
echo "CHANGELOG_COMMIT_VYOS_1X=$(git log --since "2025-01-25T00:06:56Z" --format="%H" --reverse | head -n1)" >> $GITHUB_OUTPUT

tl;dr: either in calling or internally within mikepenz/release-changelog-builder-action, fromTag is lost

Viacheslav triaged this task as Normal priority.Jan 29 2025, 10:35 AM
Apachez subscribed.Mar 11 2025, 9:11 PM

This error is still in progress over at: https://github.com/vyos/vyos-nightly-build/releases

Either there is no changelog or there is a changelog which diffs waaay to long ago so the changelog becomes HUGE and by that hard to tell what changed between two nightly build.

Viacheslav closed this task as Resolved.Mon, Apr 14, 2:13 PM
Viacheslav assigned this task to evgbondarenko.
Viacheslav subscribed.

Fixed!