Details
- Version
- -
- Is it a breaking change?
- Perfectly compatible
- Issue type
- Feature (new functionality)
Related Objects
Event Timeline
Line 86 in python/vyos/utils/process.py breaks the git commit-archive functionality since it passes a list to the rc_cmd function which eventually gets passed to popen. The new line added for this wrapper converts the list to a string similar to "['git', 'clone', 'git@<github url>', '/tmp/git-commit-archive-ypvbmg7z/repository', '--depth=1']". Since there is no wrapper, the command becomes a space followed by that string rather than the intended git clone git@<github url> /tmp/git-commit-archive-ypvbmg7z/repository --depth=1. I expect it would be better if get_wrapper returned a similar list, then if the passed in command is a string, join the wrapper and prepend to the string, otherwise if the command is a list prepend the elements of the wrapper to the list.
EDIT: I just did a quick look over the code and the Git commit-archive functionality appears to be the only place that passes a list to rc_cmd. It may make sense to fix it there instead rather than complicating the wrapper logic.