Page MenuHomeVyOS Platform
Create Task
Maniphest T6930

if 'shutdown_required' in pppoe.py always True
In progress, NormalPublicBUG
Actions

Description

https://github.com/vyos/vyos-1x/blob/a4dfb3d45ed94a67eacf5c62a4901d918c72021d/python/vyos/ifconfig/pppoe.py#L119

# remove old routes from an e.g. old VRF assignment
if 'shutdown_required':
    vrf = None
    tmp = get_interface_config(self.ifname)
    if 'master' in tmp:
        vrf = tmp['master']
    self._remove_routes(vrf)

while in bond.py

if 'shutdown_required' in config:
    self.set_admin_state('down')

Details

Version
Latest in current branch
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

sskaje created this task.Dec 3 2024, 7:51 AM
pasik subscribed.Dec 3 2024, 7:54 AM
Viacheslav triaged this task as Normal priority.Dec 3 2024, 9:23 AM
natali-rs1985 changed the task status from Open to In progress.Dec 20 2024, 8:31 AM
natali-rs1985 claimed this task.
natali-rs1985 changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
natali-rs1985 mentioned this in rVYOSONEX8f52e7f523bb: pppoe: T6930: Remove unnecessary code.Dec 20 2024, 10:05 PM
Restricted Repository Identity mentioned this in rVYOSONEX4b7f5bc06fda: Merge pull request #4246 from natali-rs1985/T6930.Dec 20 2024, 10:05 PM