Page MenuHomeVyOS Platform

Support matching ethertype in QoS policies
Closed, ResolvedPublicBUG

Description

It looks like a filter by ether* isn't implemented in vyos 1.4 and higher

steps to reproduce:

conf
set qos interface eth1 egress 'test'
set qos policy shaper test bandwidth '100gbit'
set qos policy shaper test class 22 bandwidth '22mbit'
set qos policy shaper test class 22 match 22m ether protocol 'ip'
set qos policy shaper test class 22 match 22m ether source '0c:89:0a:2e:00:01'
set qos policy shaper test class 22 queue-type 'fair-queue'
set qos policy shaper test default bandwidth '100gbit'
set qos policy shaper test default queue-type 'fair-queue'
commit

after commit tc filters is empty

vyos@vyos# tc -s filter show dev eth1
[edit]
vyos@vyos#

but qdisc and classes have been updated and look correct.

the same config on vyos 1.3 also generate filters:

conf
set interfaces ethernet eth1 traffic-policy out 'test'
set traffic-policy shaper test bandwidth '100gbit'
set traffic-policy shaper test class 22 bandwidth '22mbit'
set traffic-policy shaper test class 22 match 22m ether protocol 'ip'
set traffic-policy shaper test class 22 match 22m ether source '0c:89:0a:2e:00:01'
set traffic-policy shaper test class 22 queue-type 'fair-queue'
set traffic-policy shaper test default bandwidth '100gbit'
set traffic-policy shaper test default queue-type 'fair-queue'
commit
vyos@vyos# tc -s filter show dev eth1
filter parent 1: protocol ip pref 1 u32 chain 0 
filter parent 1: protocol ip pref 1 u32 chain 0 fh 800: ht divisor 1 
filter parent 1: protocol ip pref 1 u32 chain 0 fh 800::800 order 2048 key ht 800 bkt 0 flowid 1:16 not_in_hw  (rule hit 0 success 0)
  match 0c890a2e/ffffffff at -8 (success 0 ) 
  match 00010000/ffff0000 at -4 (success 0 )

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

HollyGurza changed the subtype of this task from "Task" to "Bug".
dmbaturin renamed this task from QoS filter by Ethernet do not work to Add ability to match ethertype in QoS policies.Feb 6 2025, 3:21 PM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin renamed this task from Add ability to match ethertype in QoS policies to Support for matching ethertype in QoS policies.Mar 12 2025, 4:18 PM
dmbaturin closed this task as Resolved.
dmbaturin moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.2) board.
dmbaturin moved this task from Open to Finished on the VyOS 1.5 Circinus board.
dmbaturin moved this task from Backlog - Bug to Completed on the VyOS Rolling board.
dmbaturin renamed this task from Support for matching ethertype in QoS policies to Support matching ethertype in QoS policies.Mar 12 2025, 4:21 PM