Page MenuHomeVyOS Platform

Table number for VRF creation is artificially limited
Closed, WontfixPublicBUG

Description

Hi All,

It appears that the configuration schema for configuring VRFs artificially and incorrectly limits the id numbers of the table id:

shanes@vyos# set vrf name test table
Possible completions:
   <100-65535>          Routing table ID
[edit]

Looking through resources online and from my own testing, the table id limit is actually 2^32-1 (4294967295), which my testing seems to confirm:

shanes@vyos:~$ sudo ip link add dev vrf-limit type vrf table 4294967295
shanes@vyos:~$ ip -d link show type vrf
15: vrf-limit: <NOARP,MASTER> mtu 65575 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 1a:26:5c:f9:cd:28 brd ff:ff:ff:ff:ff:ff promiscuity 0 allmulti 0 minmtu 1280 maxmtu 65575
    vrf table 4294967295 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 tso_max_size 65536 tso_max_segs 65535 gro_max_size 65536 gso_ipv4_max_size 65536 gro_ipv4_max_size 65536

Attempting to go over that number returns an error, as expected:

shanes@vyos:~$ sudo ip link add dev vrf-limit2 type vrf table 4294967296
Error: argument "4294967296" is wrong: invalid table ID

I think this should be a pretty simple change but I'm not aware of the process to do a PR for it. If you'd like me to submit one just let me know how and I'm happy to do it.

Details

Difficulty level
Easy (less than an hour)
Version
1.5.x
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Config syntax change (migratable)
Issue type
Improvement (missing useful functionality)

Related Objects

Event Timeline

@shaneshort this might look like a trivial one but we've already checked it out

https://github.com/vyos/vyos-1x/pull/3353

Lifting the limitation for the Kernel routing side is easy, but as we also need nftables here we will hit an out of bound error.

c-po triaged this task as Normal priority.
c-po added subscribers: Viacheslav, Apachez, pasik.