Page MenuHomeVyOS Platform
Create Task
Maniphest T6477

Adding Loki plugin to Telegraf
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Hi guys. Any plans on implementing pushing logs via Telegraf directly to Loki? Telegraf itself has a Loki plugin and if you manipulate the config /run/telegraf/telegraf.conf like this:

[ [outputs.loki]]

domain = "http://<loki-server-ip>:3100"
endpoint = "/loki/api/v1/push"
metric_name_label = "server_name"

to send the data to Loki it is working. Would be great to have that directly implemented in the config mask like “set service monitoring telegraf loki”

Thanks in advance and have a nice day :)

Best regards,
Fabian

Details

Difficulty level
Unknown (require assessment)
Version
1.4.0
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Event Timeline

Fabse created this task.Jun 12 2024, 12:48 PM
Fabse created this object in space S1 VyOS Public.
Viacheslav subscribed.Jun 12 2024, 1:32 PM

It will be easy to add; you need to generate a new CLI like with "prometheus-client" for example https://github.com/vyos/vyos-1x/blob/03d8c16a12d182a2fb2ab9f7acec5d8cb83937ba/interface-definitions/service_monitoring_telegraf.xml.in#L188-L250
And add template changes https://github.com/vyos/vyos-1x/blob/03d8c16a12d182a2fb2ab9f7acec5d8cb83937ba/data/templates/telegraf/telegraf.j2#L45-L58

@Fabse, do you want to try to add the PR?

Viacheslav changed the subtype of this task from "Task" to "Feature Request".Jun 12 2024, 1:33 PM
Viacheslav added a project: Restricted Project.
nvollmar subscribed.Jun 12 2024, 2:10 PM

Relevant telegraf documentation: https://github.com/influxdata/telegraf/blob/release-1.31/plugins/outputs/loki/README.md

pasik subscribed.Jun 12 2024, 2:19 PM
Viacheslav added a comment.Jun 12 2024, 3:39 PM

@nvollmar Do you want to claim the task?

Fabse added a comment.Jun 12 2024, 3:41 PM

Sure @Viacheslav! I'll try to add the PR. Also thanks for the documentation @nvollmar :)

nvollmar added a comment.Jun 12 2024, 4:45 PM

I would have put it on my list. @Fabse if you get stuck or need some support just slack me.

Viacheslav added a comment.Jun 21 2024, 12:48 PM

@Fabse @nvollmar Are any of you working on this task?

nvollmar added a comment.Jun 21 2024, 12:53 PM

@Viacheslav Fabse started working on it and I did have a look at the changes last week.

Viacheslav added a comment.Jun 25 2024, 10:10 AM

PR https://github.com/vyos/vyos-1x/pull/3720

set service monitoring telegraf loki url 'http://localhost'
set service monitoring telegraf loki metric-name-label 'r123'
Viacheslav changed the task status from Open to In progress.Jun 25 2024, 10:11 AM
Viacheslav claimed this task.
Viacheslav closed this task as Resolved.Jul 2 2024, 4:25 AM
Viacheslav edited projects, added VyOS 1.4 Sagitta (1.4.1); removed VyOS 1.4 Sagitta (1.4.0).
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.1) board.