Page MenuHomeVyOS Platform

Improve commit failure messages for wireless interface configuration
Closed, ResolvedPublicBUG

Description

When creating a wireless interface, it gives a traceback error:

vyos@test1# comp
[interfaces]
+ wireless wlan0 {
+     address "192.20.20.1/24"
+     description "This is an awesome interface running on VyOS"
+ }

[edit]
vyos@test1# commit
[ interfaces wireless wlan0 ]
VyOS had an issue completing a command.

We are sorry that you encountered a problem while using VyOS.
There are a few things you can do to help us (and yourself):
- Contact us using the online help desk if you have a subscription:
  https://support.vyos.io/
- Make sure you are running the latest version of VyOS available at:
  https://vyos.net/get/
- Consult the community forum to see how to handle this issue:
  https://forum.vyos.io
- Join us on Slack where our users exchange help and advice:
  https://vyos.slack.com

When reporting problems, please include as much information as possible:
- do not obfuscate any data (feel free to contact us privately if your
  business policy requires it)
- and include all the information presented below

Report time:      2024-04-23 18:00:46
Image version:    VyOS 1.5-rolling-202404230019
Release train:    current

Built by:         autobuild@vyos.net
Built on:         Tue 23 Apr 2024 02:48 UTC
Build UUID:       2270e841-0b17-4f1b-809e-e8eddaa0b015
Build commit ID:  c61c8032333f31

Architecture:     x86_64
Boot via:         installed image
System type:      KVM guest

Hardware vendor:  QEMU
Hardware model:   Standard PC (i440FX + PIIX, 1996)
Hardware S/N:
Hardware UUID:    98e92700-558d-4e21-9ace-2bebf484dc10

Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/interfaces_wireless.py", line 269, in <modu>
    c = get_config()
        ^^^^^^^^^^^^
  File "/usr/libexec/vyos/conf_mode/interfaces_wireless.py", line 104, in get_cg
    tmp = find_other_stations(conf, base, wifi['ifname'])
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/libexec/vyos/conf_mode/interfaces_wireless.py", line 54, in find_os
    for phy in os.listdir('/sys/class/ieee80211'):
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/sys/class/ieee80211'

I am testing in eve-ng lab and it does not have ieee80211 module or any wireless drivers pre-installed that's why maybe creating a wireless interface is failing.
But needs a more specific commit error for the failure of wireless interface addition.

Details

Version
1.5-rolling-202404230019
Is it a breaking change?
Perfectly compatible

Event Timeline

SrividyaA triaged this task as Normal priority.Apr 25 2024, 12:16 PM

PR https://github.com/vyos/vyos-1x/pull/3368

vyos@r4# compare 
[interfaces]
+ wireless wlan0 {
+     address "192.0.2.5/32"
+ }

[edit]
vyos@r4# commit
[ interfaces wireless wlan0 ]
Wireless module is not found!

[[interfaces wireless wlan0]] failed
Commit failed
[edit]
vyos@r4#
Viacheslav changed the task status from Open to In progress.Apr 29 2024, 9:27 AM
Viacheslav claimed this task.
Viacheslav moved this task from Open to Finished on the VyOS 1.5 Circinus board.
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0-epa3) board.
dmbaturin renamed this task from WLAN interface: Valid commit error if interface addition fails to Improve commit failure messages for wireless interface configuration.May 11 2024, 8:02 PM
dmbaturin removed a project: VyOS 1.5 Circinus.
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Unspecified (please specify) to improvement.