Page MenuHomeVyOS Platform
Create Task
Maniphest T6202

Multi-Protocol BGP is broken by 6PE patch in upstream FRR 9.1
Closed, ResolvedPublicBUG
Actions

Description

A patch to replace IPv4 nexthop on IPv6 sessions with a MPLS labelled nexthop where the IPv4 address is encoded as an IPv6 hop breaks classic multi-protocol BGP.

The upstream patch was reverted, whilst the patch is being refactored to skip this behaviour in various scenarios (including route reflectors, route servers and when the IPv6 nexthop is a global IPv6 address).

Kindly requesting that the patch to revert this behaviour get included in VyOS 1.5 nightly:
https://github.com/FRRouting/frr/commit/e575bd8e869e7cf208b45250314587d7d1e3782a

Essentially reverts FRR commit 0325116 (https://github.com/FRRouting/frr/commit/0325116a27258e1df773a046e8668a029bead60c)

Details

Difficulty level
Easy (less than an hour)
Version
1.5
Why the issue appeared?
Issues in third-party code
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

bbs2web created this task.Wed, Apr 3, 9:21 PM
bbs2web added a comment.Wed, Apr 3, 9:27 PM

Upstream project bug report:
https://github.com/FRRouting/frr/issues/15610

Appears to have yielded a revert for the patch that broke behaviour, whilst the original approach is being refactored to take corner cases in to account.

pasik added a subscriber: pasik.Thu, Apr 4, 9:19 AM
c-po claimed this task.Thu, Apr 4, 7:04 PM
c-po added a comment.Sat, Apr 6, 8:59 AM

https://github.com/FRRouting/frr/pull/15684/commits

VyOS FRR package will be rebuilt shortly

c-po closed this task as Resolved.Sat, Apr 6, 8:59 AM
c-po triaged this task as Normal priority.
c-po added a project: VyOS 1.4 Sagitta (1.4.0-epa3).
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po changed Why the issue appeared? from Will be filled on close to Issues in third-party code.
c-po moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0-epa3) board.