Page MenuHomeVyOS Platform
Create Task
Maniphest T6166

Tech support generation error for custom output location
Closed, ResolvedPublicBUG
Actions

Description

Running 1.4-rolling-202403240523-amd64 on new virtual machine, I encountered these two issues:

  • misleading UI indicators in tab-suggestions for generate tech-support archive
    • shows <file> as an option, but the invoked script seems to treat this as an output directory not an output file name
  • error running generate tech-support archive {output} if {output} is not an existing directory
    • running mkdir {output} then rerunning the same generate ... command works

Details

Difficulty level
Unknown (require assessment)
Version
1.4-rolling-202403240523-amd64
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)

Event Timeline

kevinrausch created this task.Mar 24 2024, 2:40 PM
kevinrausch created this object in space S1 VyOS Public.
kevinrausch updated the task description. (Show Details)
pasik added a subscriber: pasik.Mar 24 2024, 2:52 PM
Viacheslav added a subscriber: Viacheslav.EditedSun, Mar 31, 9:08 AM
vyos@r4:~$ generate tech-support archive /tmp/foo
Traceback (most recent call last):
  File "/usr/libexec/vyos/op_mode/generate_tech-support_archive.py", line 123, in <module>
    tmp_dir.mkdir()
  File "/usr/lib/python3.11/pathlib.py", line 1117, in mkdir
    os.mkdir(self, mode)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/foo/drops-debug_2024-03-31T12-07-09'
vyos@r4:~$

It seems hardcoded here https://github.com/vyos/vyos-1x/blob/252d03d6e419aae14ae75caed38d1b1001c916a2/src/op_mode/generate_tech-support_archive.py#L96

And for some reason does not create new dir

Viacheslav added a project: VyOS 1.5 Circinus.Sun, Mar 31, 9:08 AM
Viacheslav changed the subtype of this task from "Task" to "Bug".
HollyGurza changed the task status from Open to In progress.Thu, Apr 4, 9:52 AM
HollyGurza claimed this task.
HollyGurza added a comment.Thu, Apr 4, 9:56 AM

https://github.com/vyos/vyos-1x/pull/3242

Viacheslav closed this task as Resolved.Fri, Apr 12, 11:43 AM
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.
Viacheslav edited projects, added VyOS 1.4 Sagitta (1.4.0-epa3); removed VyOS 1.4 Sagitta.
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0-epa3) board.