Page MenuHomeVyOS Platform

PPPoE-server add pado-delay without sessions fails
In progress, NormalPublicBUG

Description

Add PPPoE-server with option pado-delay but without sessions fails

set service pppoe-server authentication local-users username user1 password 'user1'
set service pppoe-server authentication mode 'local'
set service pppoe-server client-ip-pool first range '100.64.0.1-100.64.0.100'
set service pppoe-server default-pool 'first'
set service pppoe-server gateway-address '100.64.0.1'
set service pppoe-server interface eth1
commit

Add pado-delay:

vyos@r4# set service pppoe-server pado-delay 10
[edit]
vyos@r4# commit
[ service pppoe-server ]
VyOS had an issue completing a command.

Report time:      2024-03-19 14:23:05
Image version:    VyOS 1.5-rolling-202403190019
Release train:    current

Built by:         [email protected]
Built on:         Tue 19 Mar 2024 02:19 UTC
Build UUID:       a0790664-80d6-4ab6-bac3-346ef6f1f8aa
Build commit ID:  a690a02bdcda23

Architecture:     x86_64
Boot via:         installed image
System type:      KVM guest

Hardware vendor:  QEMU
Hardware model:   Standard PC (Q35 + ICH9, 2009)
Hardware S/N:     
Hardware UUID:    166cfd25-7d3a-4eca-9ef6-0b655c9acf0f

Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/service_pppoe-server.py", line 118, in <module>
    generate(c)
  File "/usr/libexec/vyos/conf_mode/service_pppoe-server.py", line 92, in generate
    render(pppoe_conf, 'accel-ppp/pppoe.config.j2', pppoe)
  File "/usr/lib/python3/dist-packages/vyos/template.py", line 142, in render
    rendered = render_to_string(template, content, formater, location)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/vyos/template.py", line 111, in render_to_string
    rendered = template.render(content)
               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "/usr/share/vyos/templates/accel-ppp/pppoe.config.j2", line 72, in top-level template code
    {%             set pado_delay_param.value = pado_delay_param.value + ',-1:' + pado_delay[delay].sessions %}
    ^^^^^^^^^^^^^^^^^^^^^^^^^
jinja2.exceptions.UndefinedError: 'dict object' has no attribute 'sessions'



[[service pppoe-server]] failed
Commit failed
[edit]
vyos@r4#

Details

Difficulty level
Easy (less than an hour)
Version
VyOS 1.5-rolling-202403190019
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)