Page MenuHomeVyOS Platform

Improve the commit error message for the case when route-reflector-client option is defined in a peer-group
Closed, ResolvedPublicBUG

Description

Need to have a valid commit error like "% Invalid command. Not an internal neighbor" if the "route-reflect-client" option is defined in the peer-group first and internal neighbor is not defined before or in single commit.

vyos@test1# set protocols bgp peer-group peer1 address-family l2vpn-evpn route-reflector-client
[edit]
vyos@test1# commit
[ protocols bgp ]
VyOS had an issue completing a command.

We are sorry that you encountered a problem while using VyOS.
There are a few things you can do to help us (and yourself):
- Contact us using the online help desk if you have a subscription:
  https://support.vyos.io/
- Make sure you are running the latest version of VyOS available at:
  https://vyos.net/get/
- Consult the community forum to see how to handle this issue:
  https://forum.vyos.io
- Join us on Slack where our users exchange help and advice:
  https://vyos.slack.com

When reporting problems, please include as much information as possible:
- do not obfuscate any data (feel free to contact us privately if your
  business policy requires it)
- and include all the information presented below

Report time:      2024-03-07 05:20:01
Image version:    VyOS 1.5-rolling-202402120819
Release train:    current

Built by:         autobuild@vyos.net
Built on:         Mon 12 Feb 2024 10:20 UTC
Build UUID:       b1a917a9-cda4-49ad-a327-58321f1067dc
Build commit ID:  8c5299e1cf7c7b

Architecture:     x86_64
Boot via:         installed image
System type:      KVM guest

Hardware vendor:  QEMU
Hardware model:   Standard PC (i440FX + PIIX, 1996)
Hardware S/N:
Hardware UUID:    98e92700-558d-4e21-9ace-2bebf484dc10

Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/protocols_bgp.py", line 611, in <module>
    apply(c)
  File "/usr/libexec/vyos/conf_mode/protocols_bgp.py", line 602, in apply
    frr_cfg.commit_configuration(bgp_daemon)
  File "/usr/lib/python3/dist-packages/vyos/frr.py", line 482, in commit_configuration
    raise ConfigurationNotValid(f'Config commit retry counter ({count_max}) exceeded for {daemon} dameon!')
vyos.frr.ConfigurationNotValid: Config commit retry counter (5) exceeded for bgpd dameon!



[[protocols bgp]] failed
Commit failed
[edit]
vyos@test1#

[edit]
vyos@test1# comp
[protocols bgp peer-group peer1]
+ address-family {
+     l2vpn-evpn {
+         route-reflector-client
+     }
+ }
[protocols bgp]
+ neighbor 192.0.0.2 {
+     peer-group "peer1"
+     remote-as "64540"
+ }

[edit]
vyos@test1# commit
[edit]

FRR config:

test1(config-router)# address-family l2vpn evpn
test1(config-router-af)# neighbor peer1 activate
test1(config-router-af)# neighbor peer1 route-reflector-client
% Invalid command. Not an internal neighbor
test1(config-router-af)# exit

Details

Version
1.5-rolling-202402120819
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

HollyGurza changed the task status from Open to In progress.Mar 19 2024, 4:47 AM
HollyGurza claimed this task.

What about OSPF,OSPFv3 and the other routing daemons?

Viacheslav changed the task status from In progress to Needs testing.Apr 9 2024, 4:12 PM
Viacheslav subscribed.

Was it fixed?

i think yes, now we will show frr logs for unhandled exceptions and normal short messages for others e.g. route-reflector-client only supported for iBGP peers

Viacheslav moved this task from In Progress to Finished on the VyOS 1.5 Circinus board.
dmbaturin renamed this task from Valid commit error for route-reflector-client option defined in peer-group to Improve the commit error message for the case when route-reflector-client option is defined in a peer-group.May 11 2024, 5:11 PM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Unspecified (please specify) to Bug (incorrect behavior).