Page MenuHomeVyOS Platform

bnx2x NIC causes a commit error due to incorrect implementation of EEE status reading
Closed, ResolvedPublicBUG


When adding a bnx2x interface the following error is raised

Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/", line 385, in <module>
  File "/usr/libexec/vyos/conf_mode/", line 273, in verify
  File "/usr/libexec/vyos/conf_mode/", line 309, in verify_ethernet
    ethtool = Ethtool(ifname)
  File "/usr/lib/python3/dist-packages/vyos/", line 153, in __init__
    self._eee_enabled = bool('enabled' in out.splitlines()[2])
$ sudo ethtool --show-eee eth0
EEE Settings for eth0:
        EEE status: not supported

At first I thought the bug was an out-of-bounds access, which it is in the case for bnx2x but the real bug is that the shim is reading the EEE status from the wrong line number.


Difficulty level
Easy (less than an hour)
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)