Page MenuHomeVyOS Platform

QoS hide attempts to delete qdisc from devices
Closed, ResolvedPublicBUG

Description

We should QoS hide attempts to delete qdisc from devices.
The current behaviour

set qos policy shaper SHAPER bandwidth '1000mbit'
set qos policy shaper SHAPER class 10 bandwidth '70mbit'
set qos policy shaper SHAPER class 10 match SYN ip tcp syn
set qos policy shaper SHAPER default bandwidth '500mbit'


vyos@r4# commit
[ qos ]
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.
Error: Cannot find specified qdisc on specified device.
Error: Cannot delete qdisc with handle of zero.

It shows attempts to delete qdisc from all network interfaces, i.e

tc qdisc del dev lo parent ffff:
tc qdisc del dev lo root
tc qdisc del dev eth0 parent ffff:
tc qdisc del dev eth0 root
tc qdisc del dev eth1 parent ffff:
tc qdisc del dev eth1 root
tc qdisc del dev eth2 parent ffff:
tc qdisc del dev eth2 root
tc qdisc del dev eth3 parent ffff:
tc qdisc del dev eth3 root
tc qdisc del dev eth4 parent ffff:
tc qdisc del dev eth4 root
tc qdisc del dev eth5 parent ffff:
tc qdisc del dev eth5 root
tc qdisc del dev pim6reg parent ffff:
tc qdisc del dev pim6reg root
tc qdisc del dev pod-NET01 parent ffff:
tc qdisc del dev pod-NET01 root
tc qdisc del dev veth0 parent ffff:
tc qdisc del dev veth0 root
tc qdisc del dev veth1 parent ffff:
tc qdisc del dev veth1 root

Needs to hide it https://github.com/vyos/vyos-1x/blob/98c6434e7433e6a0aa1034b39c9130d390bbe591/src/conf_mode/qos.py#L208-L209

Details

Difficulty level
Unknown (require assessment)
Version
VyOS 1.5-rolling-202402080022
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Cosmetic issue (typos etc.)