Page MenuHomeVyOS Platform

When using git as config-management commit-archive, comment is not used as commit message
Closed, InvalidPublicFEATURE REQUEST

Description

Hey,

When using the git+https location for commit archive, it just uses the generic "commit" message as commit message.
However, it would be nice if the comment you can append when commiting changes is used in the git commit message.

Like, if I make some changes to lets say the DHCP server, and run the following command:

commit "DHCP changes"

Then the git commit that gets pushed to my git repo just has the commit message commit.

Can this be changed, so the comment is included in the git commit message?

Details

Version
VyOS 1.4.0-rc3
Is it a breaking change?
Perfectly compatible
Issue type
Unspecified (please specify)

Event Timeline

Unknown Object (User) created this task.Jan 29 2024, 9:54 PM
Viacheslav triaged this task as Wishlist priority.Jan 30 2024, 8:17 AM
Viacheslav changed the subtype of this task from "Bug" to "Feature Request".

I explored implementing this feature, turns out it is already available.
Correct syntax for commit messages is commit comment "example message".

PR opened for vyos-documentation to capture this:
https://github.com/vyos/vyos-documentation/pull/1405

Unknown Object (User) added a comment.Apr 28 2024, 8:27 AM

You are right - I wonder why it didn't work when I tested it back then. (Most likely I forgot to write "comment")

dmbaturin edited projects, added Invalid; removed Bugs, VyOS 1.5 Circinus.
dmbaturin changed Issue type from Bug (incorrect behavior) to Unspecified (please specify).