Page MenuHomeVyOS Platform
Create Task
Maniphest T5978

ethernet: hw-tc-offload does not actually get enabled on the NIC
Closed, ResolvedPublicBUG
Actions

Description

From https://github.com/vyos/vyos-1x/blob/current/python/vyos/ifconfig/ethernet.py#L455

self.set_hw_tc_offload(dict_search('offload.hw-tc-offload', config) != None) it should use underscores over a hyphen

Details

Difficulty level
Easy (less than an hour)
Version
1.4.0-rc1
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

c-po changed the task status from Open to In progress.Jan 23 2024, 6:57 AM
c-po claimed this task.
c-po created this task.
c-po added a project: VyOS 1.5 Circinus.
c-po added a comment.Jan 23 2024, 7:03 AM

https://github.com/vyos/vyos-1x/pull/2881

pasik added a subscriber: pasik.Jan 23 2024, 9:25 AM
dmbaturin triaged this task as High priority.Jan 23 2024, 6:57 PM
c-po closed this task as Resolved.Feb 1 2024, 9:05 AM
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
c-po moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.