Page MenuHomeVyOS Platform

Replace partprobe with partx due to unable to install VyOS
Closed, ResolvedPublicBUG

Description

Some customers have issues with partprobe

The error I got was  Unable to install VyOS:

https://vyos.slack.com/archives/C01A6CJFW1F/p1703900905673669

The fix is replacement partprobe {drive_path} with partx -u {drive_path} https://github.com/vyos/vyos-1x/blob/d8decd67a719eb690bbbead68ff6a93be172869a/python/vyos/system/disk.py#L81C7-L81C7

Details

Difficulty level
Normal (likely a few hours)
Version
vyos-1.5-rolling-202312290919-amd64
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

This affected my install. PR submitted with fix above (with very basic testing done successfully) in the link below.

https://github.com/vyos/vyos-1x/pull/2760

Viacheslav changed the task status from Open to In progress.Jan 6 2024, 6:00 PM
Viacheslav assigned this task to mec.
mec changed Difficulty level from Unknown (require assessment) to Normal (likely a few hours).Jan 6 2024, 9:36 PM
Viacheslav changed the task status from In progress to Needs testing.Jan 7 2024, 1:02 PM

How come partprobe fails but not partx?

I said it in the PR, but I'll say it here too -- I really don't have an idea, nor do I have enough knowledge of the codebase to get debugging data. I suspect that partprobe is either getting an error back from the kernel or is throwing its own error, and partx isn't. if I could step through the process and look at a couple things (like, is some partition actually mounted when partprobe runs, which could trigger this?) I would, assuming I've got the spare cycles. I don't at the immediate moment, and especially not to run through the code to try and figure out debugging on my own. Even being told "set debug here, here, and here, then retry the install" would help.