Page MenuHomeVyOS Platform
Create Task
Maniphest T5805

Missed per-interface statistic in telegraf
Closed, ResolvedPublicBUG
Actions

Description

Hello, after my latest update, I noticed that there is no data in the network interfaces graphs. After conducting a small investigation, I discovered that in https://vyos.dev/rVYOSONEX6a10149ca56e77dce91c9771b48b0b3fd8c9ab9e, Viacheslav removed

[[inputs.net]]

and replaced it with

[[inputs.nstat]]

in response to a deprecated message. However, if we check the net plugin information (https://github.com/influxdata/telegraf/blob/master/plugins/inputs/net/README.md), we can see that it is deprecated only for the option "ignore_protocol_stats = false" because they recommend using inputs.nstat for this specific data, not for all network data. inputs.nstat doesn't provide information about per-interface load.

In this scenario, I believe it would be beneficial to re-enable both plugins and set "ignore_protocol_stats = true" for the net plugin.

Details

Version
1.4-rolling-202312041649 (sagitta)
Is it a breaking change?
Behavior change

Related Objects

Event Timeline

vfomkin created this task.Dec 6 2023, 2:43 PM
pasik subscribed.Dec 6 2023, 9:57 PM
Viacheslav subscribed.Dec 7 2023, 8:35 AM

Could you create a PR?

vfomkin added a comment.Dec 8 2023, 12:22 PM

https://github.com/vyos/vyos-1x/pull/2589

Restricted Repository Identity mentioned this in rVYOSONEX383c40c547c7: T5805: telegraf: re-add network metrics.Dec 8 2023, 2:56 PM
c-po mentioned this in rVYOSONEX9c8a7a987fcb: T5805: telegraf: re-add network metrics.Dec 8 2023, 2:56 PM
Viacheslav changed the task status from Open to Needs testing.Dec 8 2023, 3:01 PM
Viacheslav assigned this task to vfomkin.
Viacheslav closed this task as Resolved.Jan 20 2024, 2:00 PM
Viacheslav moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
faekz0r subscribed.EditedDec 18 2024, 11:33 AM

The issue is still there in VyOS 1.4 Sagitta and 1.5-rolling-202412160007

show system image
Name                      Default boot    Running
------------------------  --------------  ---------
1.5-rolling-202412160007  Yes             Yes

cat /etc/telegraf/telegraf.conf | grep inputs.net
# [[inputs.net]]

I see the correct fix here, but not sure what's up with it: https://vyos.dev/rVYOSONEX9c8a7a987fcb99adaa9ba8d423640441e8725ecf
https://github.com/vyos/vyos-1x/pull/2589