Page MenuHomeVyOS Platform
Create Task
Maniphest T5755

Running set pki ca NAME certificate with a name with spaces breaks the config
Resolved (N/A)Public
Actions

Description

When importing a CA certificate, it is possible to import like this:

set pki ca "My Root Certificate" certificate BASE64DATA

This works fine, and saves fine.
However, when saving the config and restarting, the config fails to load, since it is saved like this, which seems to be invalid:

pki {
    ca My Root Certificate {
        certificate "BASE64DATA"
    }
}

It is also possible to to use dots when importing a certificate - not sure if that is causing problems.

It seems like some input validation is missing.

Details

Difficulty level
Unknown (require assessment)
Version
- VyOS 1.4-rolling-202311151958
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

GurliGebis created this task.Nov 16 2023, 9:13 PM
GurliGebis created this object in space S1 VyOS Public.
pasik added a subscriber: pasik.Nov 16 2023, 9:45 PM
Viacheslav triaged this task as Normal priority.Jan 20 2024, 2:11 AM
Viacheslav added a project: VyOS 1.5 Circinus.Thu, Apr 18, 11:32 AM
Viacheslav closed this task as Resolved N/A.Thu, Apr 18, 11:43 AM
Viacheslav added a subscriber: Viacheslav.

Not reproduced on VyOS 1.5-rolling-202404141045

vyos@r-left# set pki ca "my test ca name" certificate 'MIIDnTCCAoWgAwIBAgIUFvyB2rY0V1V6AaIpPWHCftGRwN8wDQYJKoZIhvcNAQELBQAwVzELMAkGA0IxEzARBgNVBAgMClNvbWUtU3RhdGUxEjAQBgNVBAcMCVNvbWUtQ2l0eTENMAsGA1UECgwEVnlPUzEQMA4GA1UEAwwHdnlvcy5pbzAeFw0yNDA0MTgxMTM3MzZaFw0yOTA0MzZaMFcxCzAJBgNVBAYTAkdCMRMwEQYDVQQIDApTb21lLVN0YXRlMRIwEAYDVQQHDAlTb21lLUNpdHkxDTALBgNVBAoMBFZ5T1MxEDAOBgNVBAMMB3Z5b3MuaW8wggEiMA0GCQEBAQUAA4IBDwAwggEKAoIBAQCKEVxs7gdzmnN4iMinvXN1vdGaT+v3TOnHSXbBkWHnt9YdWmo8UoqFpVqyVM3E8xmoT+3HOXJeWkKArEpMkGo93kWaGo0f25KGEFWbS2ttgNA9cqH9PGa42XTKyTY+5ZoIWaQQzNNiUSaIoslRrMSV4V2yQs90ECxR37ezlV2RAIHEhZ6mizUkMkuSmdjqRolh2tpF1MoisyhspFPXBC6lJ8d0jFZEi1tP3tlQjqVEWPjTvtddy34iOLFeUjBF5cOwfmpVLzWBVLbIxJr5ZHamGeQIabn36Jg1u0+/6p7hb8avqBW4dT0K8UykWVqgjQ4W4rM7AgMBAAGjYTBfMA8GA1UdEwEB/wQFMAMBAf8wDgYDVR0PAgGGMB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEFBQcDATAdBgNVHQ4EFgQUxEx+IVaoLb7M/SW9AkCVRaXCNTUwDQYJKoZIhvcNAQELBQADggEBAGjV6WiH4Z+hfdANG8oWgY0xsHmUZg8dCjwqO5GMwjBVIuu8GuoZu0JobtLa097behWcgCkwjvKBffuwCu542WbFkxdXzBLZjSAc+K3itegZIuy4jqRO5z6Q0IbPSaFUhR4HhfwejwlyXgjNCFzEMzwoDL2/3PXjWyilkqthYyFcx092tgwiXtnfO9z9Xm/YQHQmRG2VWzLEwucOhV698xnqFgRJk3uKqcDN9KjF+5v32OQ0eis7GHn1aJim5aUee1nnCRFdQO0llNJRwF6fIaICzKLwa7zzMjF7HhRehh5kpwY8omcQX7xYz7GJag4='



  Invalid value
  Value validation failed
  Set failed

Reopen if required, just provide the "set of commands" to reproduce

GurliGebis added a comment.Sat, Apr 20, 9:04 AM

I just built and tested with the latest sagitta commits, and it is preventing it now as expected.
So I would say it can be closed as fixed, since it has been fixed some time between November and now.

c-po moved this task from Need Triage to Finished on the VyOS 1.5 Circinus board.Wed, Apr 24, 5:46 AM