Page MenuHomeVyOS Platform
Create Task
Maniphest T5727

validator: Use native URL validator instead of regex-based validator
Closed, ResolvedPublicBUG
Actions

Description

Replace regex-based URL validator with native validator from vyos-utils.

The current regex validator doesn't capture all use cases, for example:

  • http:/foo.example.com (with single /) passes incorrectly
  • http://1.2.3.4.5/foo passes incorrectly
  • http://[::1]/foo (IPv6-based) fails incorrectly

Details

Difficulty level
Easy (less than an hour)
Version
1.4 1.5
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Revisions and Commits

Restricted Diffusion Commit

Event Timeline

indrajitr claimed this task.Nov 9 2023, 10:01 PM
indrajitr created this task.
GitHub <[email protected]> closed this task as Resolved by committing Restricted Diffusion Commit.Nov 10 2023, 7:04 AM
GitHub <[email protected]> added a commit: Restricted Diffusion Commit.
pasik added a subscriber: pasik.Nov 10 2023, 9:23 AM