Page MenuHomeVyOS Platform
Create Task
Maniphest T5716

PPPoE-server shaper template bug down-limiter option does not rely on fwmark
Closed, ResolvedPublicBUG
Actions

Description

PPPoE-server shaper template bug, down-limiter option does not rely on fwmark
https://github.com/vyos/vyos-1x/blob/d8a71978b4628e30b25346f4ff690e8705020408/data/templates/accel-ppp/config_shaper_radius.j2#L14-L16

Details

Version
VyOS 1.5-rolling-202311040021
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)

Related Objects

Event Timeline

Viacheslav created this task.Nov 6 2023, 9:30 AM
Viacheslav changed the task status from Open to In progress.Nov 6 2023, 10:06 AM
Viacheslav claimed this task.
Viacheslav added a comment.Nov 6 2023, 10:19 AM

PR https://github.com/vyos/vyos-1x/pull/2440

Restricted Repository Identity mentioned this in rVYOSONEX02d84bcf4dcf: Merge pull request #2440 from sever-sever/T5716.Nov 6 2023, 8:33 PM
Viacheslav mentioned this in rVYOSONEXcf9229544a30: T5716: Fix accel-ppp template down-limiter does not rely on fwmark.Nov 6 2023, 8:33 PM
Restricted Repository Identity mentioned this in rVYOSONEXcda6fd0f78cc: T5716: Fix accel-ppp template down-limiter does not rely on fwmark.Nov 7 2023, 7:18 AM
Restricted Repository Identity mentioned this in rVYOSONEX9c82fea9f086: Merge pull request #2450 from vyos/mergify/bp/sagitta/pr-2440.Nov 7 2023, 7:28 AM
Restricted Repository Identity mentioned this in rVYOSONEXb7ff6f81e2bd: Merge pull request #2451 from sever-sever/T5716.Nov 7 2023, 8:15 AM
Viacheslav mentioned this in rVYOSONEXd8ffbbe72c79: T5716: Fix smoketest for accel-ppp limiter tbf.Nov 7 2023, 8:15 AM
Restricted Repository Identity mentioned this in rVYOSONEX91917fc1c99f: T5716: Fix smoketest for accel-ppp limiter tbf.Nov 7 2023, 8:16 AM
Restricted Repository Identity mentioned this in rVYOSONEX11ca0a12272a: Merge pull request #2452 from vyos/mergify/bp/sagitta/pr-2451.Nov 7 2023, 1:56 PM
Viacheslav closed this task as Resolved.Nov 8 2023, 8:32 AM
Viacheslav moved this task from Open to Finished on the VyOS 1.5 Circinus board.
Viacheslav added a project: VyOS 1.4 Sagitta.
Viacheslav moved this task from Open to Finished on the VyOS 1.4 Sagitta board.