Page MenuHomeVyOS Platform
Create Task
Maniphest T5648

ldpd neighbour template errors
Closed, ResolvedPublicBUG
Actions

Description

The ldpd template has some errors in the section configuring neighbours:

Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/protocols_mpls.py", line 144, in <module>
    generate(c)
  File "/usr/libexec/vyos/conf_mode/protocols_mpls.py", line 76, in generate
    mpls['frr_ldpd_config'] = render_to_string('frr/ldpd.frr.j2', mpls)
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/vyos/template.py", line 111, in render_to_string
    rendered = template.render(content)
               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "/usr/share/vyos/templates/frr/ldpd.frr.j2", line 17, in top-level template code
    {%         for neighbor, neighbor_config in ldp.neighbor %}
    ^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: too many values to unpack (expected 2)

I observed this on a fresh build of the sagitta branch, but the bug is also present on current.

Details

Version
1.4
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

devon created this task.Oct 12 2023, 5:49 AM
devon claimed this task.Oct 12 2023, 5:53 AM

PR: https://github.com/vyos/vyos-1x/pull/2357

pasik subscribed.Oct 12 2023, 7:58 AM
Restricted Repository Identity mentioned this in rVYOSONEXc4bea386c662: Merge pull request #2357 from devon-mar/ldpd-template-errors.Oct 12 2023, 5:01 PM
devon mentioned this in rVYOSONEXdf6ced3811eb: ldpd: T5648: Fix ldpd template errors.Oct 12 2023, 5:01 PM
Viacheslav changed the task status from Open to Needs testing.Oct 14 2023, 7:32 AM
fernando subscribed.Nov 6 2023, 7:49 PM

after merge this ldp bug fixed , I saw that now it's already working . Could you check it ? I've tested on a lab and it seems to work :

vyos@vyos# run show version
Version:          VyOS 1.5-rolling-202311060023
Release train:    current

Built by:         autobuild@vyos.net
Built on:         Mon 06 Nov 2023 01:44 UTC
Build UUID:       f6fd8df2-7037-43a4-af1b-dccff2ebebde
Build commit ID:  74b06c308bb631

Architecture:     x86_64
Boot via:         installed image
System type:      KVM guest

Hardware vendor:  QEMU
Hardware model:   Standard PC (i440FX + PIIX, 1996)
Hardware S/N:
Hardware UUID:    e8efca04-b3c4-4e51-9e95-fffffc477abe

Copyright:        VyOS maintainers and contributors
[edit]
vyos@vyos# run show configuration commands | match mpls
set protocols mpls ldp discovery transport-ipv4-address '172.16.50.44'
set protocols mpls ldp interface 'eth1'
set protocols mpls ldp neighbor 1.1.1.1 password 'test01'
set protocols mpls ldp neighbor 1.1.1.1 session-holdtime '300'
set protocols mpls ldp neighbor 1.1.1.1 ttl-security '30'
set protocols mpls ldp router-id '172.16.50.44'
set protocols mpls ldp targeted-neighbor ipv4 address '1.1.1.1'
fernando added a comment.Nov 6 2023, 7:50 PM

@devon

devon added a comment.Nov 7 2023, 5:55 AM

It's fixed in 1.5-rolling-202311060023 but the bug is still present in 1.4.

Restricted Repository Identity mentioned this in rVYOSONEXf9bc65c93fb7: ldpd: T5648: Fix ldpd template errors.Nov 7 2023, 7:07 AM
Viacheslav subscribed.Nov 7 2023, 7:09 AM

Backport to 1.4 https://github.com/vyos/vyos-1x/pull/2449

Restricted Repository Identity mentioned this in rVYOSONEX366ee7d81082: Merge pull request #2449 from vyos/mergify/bp/sagitta/pr-2357.Nov 7 2023, 7:27 AM
fernando added a comment.Nov 8 2023, 7:07 PM

tested on 1.4-rolling-202311080309

vyos@vyos:~$ show version
Version:          VyOS 1.4-rolling-202311080309
Release train:    sagitta

Built by:         autobuild@vyos.net
Built on:         Wed 08 Nov 2023 03:09 UTC
Build UUID:       b7e2acdd-77bc-45f9-8415-d1e49f3da063
Build commit ID:  987bbc8be52abc

Architecture:     x86_64
Boot via:         installed image
System type:      KVM guest

Hardware vendor:  QEMU
Hardware model:   Standard PC (i440FX + PIIX, 1996)
Hardware S/N:
Hardware UUID:    e8efca04-b3c4-4e51-9e95-fffffc477abe

Copyright:        VyOS maintainers and contributors
vyos@vyos:~$ show configuration commands | mna

vyos@vyos:~$ show configuration commands | match mpls
set protocols mpls ldp discovery transport-ipv4-address '172.16.50.44'
set protocols mpls ldp interface 'eth1'
set protocols mpls ldp neighbor 1.1.1.1 password 'test01'
set protocols mpls ldp neighbor 1.1.1.1 session-holdtime '300'
set protocols mpls ldp neighbor 1.1.1.1 ttl-security '30'
set protocols mpls ldp router-id '172.16.50.44'
set protocols mpls ldp targeted-neighbor ipv4 address '1.1.1.1'
fernando closed this task as Resolved.Nov 8 2023, 7:07 PM
Viacheslav moved this task from Open to Finished on the VyOS 1.5 Circinus board.Nov 9 2023, 7:41 AM
Viacheslav moved this task from Open to Finished on the VyOS 1.4 Sagitta board.