Page MenuHomeVyOS Platform
Create Task
Maniphest T5621

Show uncommited "commands" (compare | commands)
Closed, InvalidPublic
Actions

Description

Is it possible to activate the "| commands"-option when comparing the candidate config?

For example:

[edit]
user@vyos: set firewall ipv4 forward filter rule 1 description 'Example'
[edit]
user@vyos: set firewall ipv4 forward filter rule 1 action accept
[edit]
user@vyos: set firewall ipv4 forward filter rule 1 destination address 1.1.1.1
[edit|
user@vyos: compare | commands
 set firewall ipv4 forward filter rule 1 action accept
 set firewall ipv4 forward filter rule 1 description 'Example'
 set firewall ipv4 forward filter rule 1 destination address 1.1.1.1

I would personally leave the error message when using the "show | commands" and instead implement this feature under the "compare" command.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Improvement (missing useful functionality)

Event Timeline

aga triaged this task as Wishlist priority.Sep 29 2023, 12:02 AM
aga created this task.
aga created this object in space S1 VyOS Public.
pasik added a subscriber: pasik.Sep 29 2023, 7:16 AM
n.fort added a subscriber: n.fort.Sep 29 2023, 10:43 AM

You mean this existing option, or I am missing something?

vyos@vyos-suri:~$ conf
[edit]
vyos@vyos-suri# set int eth eth0 description TEST
[edit]
vyos@vyos-suri# set serv ssh port 8877
[edit]
vyos@vyos-suri# set system host-name foo
[edit]
vyos@vyos-suri# compare 
[interfaces ethernet eth0]
+ description "TEST"
[service ssh]
+ port "8877"
[system]
- host-name "vyos-suri"
+ host-name "foo"

[edit]
vyos@vyos-suri# compare commands
delete system host-name 'vyos-suri'
set interfaces ethernet eth0 description 'TEST'
set service ssh port '8877'
set system host-name 'foo'

[edit]
vyos@vyos-suri#
aga added a comment.Sep 29 2023, 2:28 PM

@n.fort Ahh yes.. I'm sorry, thats embarassing now.. I've probably always overlooked it since it's before the "<Enter>" which I usually always expect as the first option (from other OSs aswell).. And probably because I'm used to the command being after the pipe aswell.. Still good to know now that the feature exists..

aga closed this task as Resolved.Sep 29 2023, 2:30 PM
Viacheslav changed the task status from Resolved to Invalid.Sep 29 2023, 4:10 PM