Page MenuHomeVyOS Platform

ipoe-server: external-dhcp(dhcp-relay) not woking / not implemented
Closed, ResolvedPublicBUG

Description

Hello guys,
after trying to configure vyos for a BNG role with an external dhcp-server, that feature was not working as intended.
There seems to be a cli definition for it but the configuration never gets applied to the ipoe.conf file.

service {
    ipoe-server {
        authentication {
            mode noauth
        }
        interface eth2 {
            external-dhcp {
                dhcp-relay 12.0.0.1
                giaddr 11.0.0.1
            }
        }
    }

results in(ipoe.conf)

### generated by ipoe.py ###
(...)
[ipoe]
verbose=1
interface=eth2,shared=1,mode=L2,ifcfg=1,start=dhcpv4,ipv6=1
noauth=1
proxy-arp=1
(...)

but should be something like:

### generated by ipoe.py ###
(...)
[ipoe]
verbose=1
interface=eth2,shared=1,mode=L2,ifcfg=1,start=dhcpv4,ipv6=1,relay=12.0.0.1,giaddr=11.0.0.1
noauth=1
proxy-arp=1
(...)

Digging a bit deeper i discovered, that the feature was indeed not mentioned in ipoe.config.j2
or in service:ipoe-server.py

Am i missing something?
I am new to contributing to vyos, but I can provide a working fix. ;)

BR
Niklas

Details

Difficulty level
Easy (less than an hour)
Version
VyOS 1.4-rolling-202308230020
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

Viacheslav changed the task status from Open to Needs testing.Sep 3 2023, 9:13 AM

@Niklasthegeek Could you re-check and close it if it was fixed?

@Viacheslav Sure. I am on VyOS 1.4-rolling-202309040919 and the issue is fixed. Config gets build correctly