Page MenuHomeVyOS Platform
Create Task
Maniphest T5538

Change order within variable lb_config_tmpl to fit order of manpage and fix some typos
Closed, ResolvedPublicBUG
Actions

Description

Feature request:

Change order within variable lb_config_tmpl (scripts/build-vyos-image) to fit order of manpage over at:

https://manpages.debian.org/bookworm/live-build/lb_config.1.en.html

Bug report:

Fix typos within variable lb_config_tmpl (scripts/build-vyos-image) regarding:

--architectures -> --architecture
--binary-images -> --binary-image
--bootloader -> --bootloaders

according to https://manpages.debian.org/bookworm/live-build/lb_config.1.en.html

Details

Difficulty level
Unknown (require assessment)
Version
VyOS 1.4-rolling-202308310021
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

Apachez claimed this task.Sep 2 2023, 10:45 AM
Apachez created this task.
Apachez added a comment.Sep 2 2023, 11:00 AM

PR created: https://github.com/vyos/vyos-build/pull/391

Apachez added a comment.Sep 3 2023, 5:02 AM

Was missing quotes around the variable within lb_config_tmpl like so:

--chroot-squashfs-compression-type "{{squashfs_compression_type}}" \

Fixed by:

https://vyos.dev/R3:9403274bf29110b3d1aa5be99a029a97103e02f1

Apachez added a comment.Sep 3 2023, 5:03 AM

Verified working with VyOS 1.4-rolling-202309030023.

Apachez closed this task as Resolved.Sep 3 2023, 5:04 AM