Page MenuHomeVyOS Platform
Create Task
Maniphest T5436

vyos-preconfig-bootup.script is missing
Closed, ResolvedPublicBUG
Actions

Description

According to https://docs.vyos.io/en/latest/automation/command-scripting.html there should exist both preconfig and postconfig scripts at following location:

/config/scripts/vyos-preconfig-bootup.script
/config/scripts/vyos-postconfig-bootup.script

However in current 1.4-rolling the preconfig script is missing:

vyos@vyos:~$ ls -la /config/scripts/
total 12
drwxrwsr-x 2 root vyattacfg 4096 Jun 28 05:17 .
drwxrwxr-x 9 root vyattacfg 4096 Aug  4 08:28 ..
-rwxrwxr-x 1 root vyattacfg  230 Aug  3 12:01 vyos-postconfig-bootup.script

Details

Difficulty level
Unknown (require assessment)
Version
VyOS 1.4-rolling-202308030317
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

Apachez created this task.Aug 4 2023, 6:32 AM
Viacheslav added a subscriber: Viacheslav.Aug 4 2023, 8:39 AM

Could be added the same way https://github.com/vyos/vyos-1x/blob/8f161eaae78769e5a1d573e43f00a0f439aadc28/debian/vyos-1x.postinst#L126-L139

Apachez claimed this task.Aug 4 2023, 10:15 AM
Apachez added a comment.Aug 4 2023, 10:42 AM

PR created: https://github.com/vyos/vyos-1x/pull/2132

Apachez added a comment.Aug 5 2023, 7:31 PM

I need some help with this one.

PR2132 fixes so that the file exists where its supposed to exist (using postconfig as reference) and is being called by init-script etc.

That is during a fresh install the file shows up in /config/scripts.

However during a system upgrade (add system image) the file newer shows up in /config/scripts (if the file not already exists in /config/scripts it should be copied from /usr/lib/live/mount/rootfs/1.4-rolling-202308050917.squashfs/opt/vyatta/etc/config/scripts# vi vyos-preconfig-bootup.script).

So I guess a migrate-script must be created or something to properly fix this?

Or should this be handled statically by the init-script (copy file if it not already exists and then execute it - if so then this must be fixed for the postconfig-file aswell)?

Apachez mentioned this in T5440: Restore pre/postconfig scripts if user deleted them.Aug 5 2023, 9:33 PM
Apachez closed this task as Resolved.Aug 5 2023, 9:35 PM

Added task https://vyos.dev/T5440 to fix the issue of preconfig-script doesnt show up in /config/scripts after system upgrade (add system image).

The task will also fix this for postconfig-script to cover for the case if the user accidently deletes the pre/postconfig scripts in /config/scripts.

Apachez reopened this task as Open.Aug 5 2023, 9:36 PM
Apachez added a comment.Aug 5 2023, 10:01 PM

PR created: https://github.com/vyos/vyos-1x/pull/2135

Apachez added a comment.Aug 14 2023, 9:50 PM

Verified in VyOS 1.4-rolling-202308140557:

1: Delete the scripts (vyos-preconfig-bootup.script and vyos-postconfig-bootup.script) in /config/scripts and reboot.

2: The scripts have been restored after reboot:

vyos@vyos:~$ sudo ls -la /config/scripts
total 16
drwxrwsr-x 2 root vyattacfg 4096 Aug 14 23:49 .
drwxrwxr-x 9 root vyattacfg 4096 Aug 14 23:49 ..
-rwxr-x--- 1 root vyattacfg  230 Aug 14 23:49 vyos-postconfig-bootup.script
-rwxr-x--- 1 root vyattacfg  225 Aug 14 23:49 vyos-preconfig-bootup.script
Apachez closed this task as Resolved.Aug 14 2023, 9:51 PM
Apachez added a comment.Sep 30 2023, 8:31 PM

PR created: https://github.com/vyos/vyos-1x/pull/2326

Apachez reopened this task as Open.Sep 30 2023, 8:31 PM
pasik added a subscriber: pasik.Oct 1 2023, 9:06 AM
Apachez changed the task status from Open to Needs testing.Oct 3 2023, 9:38 AM

Merged, will show up in nightly 2023-10-04.

Apachez closed this task as Resolved.Oct 10 2023, 4:59 AM

Verified in VyOS 1.5-rolling-202310090023:

  1. Deleted /config/scripts directory and rebooted.
  1. VyOS came back online without any errors/warnings in the console and the directory /config/scripts has been recreated along with its files:
vyos@vyos:~$ ls -la /config/scripts
total 16
drwxrwsr-x 2 root vyattacfg 4096 Oct 10 06:58 .
drwxrwsr-x 1 root vyattacfg 4096 Oct 10 06:57 ..
-rwxr-x--- 1 root vyattacfg  230 Oct 10 06:58 vyos-postconfig-bootup.script
-rwxr-x--- 1 root vyattacfg  225 Oct 10 06:57 vyos-preconfig-bootup.script

Task can be set to resolved.