Page MenuHomeVyOS Platform
Create Task
Maniphest T5118

Cleanup vestigial ntp completion script
Closed, ResolvedPublicBUG
Actions

Description

Remove vestigial completion script src/completion/list_ntp_servers.sh which isn't used anymore.

This isn't used anymore after migration from ntpd to chrony as part of T3008.

Details

Version
1.4
Is it a breaking change?
Perfectly compatible
Issue type
Cosmetic issue (typos etc.)

Related Objects

Event Timeline

indrajitr created this task.Mar 28 2023, 10:53 PM
Restricted Repository Identity mentioned this in rVYOSONEX1221bfa29ee8: Merge pull request #1917 from indrajitr/chrony-cleanup.Mar 29 2023, 5:59 AM
indrajitr mentioned this in rVYOSONEXb9ab6ab5987e: ntp: T5118: Remove vestigial ntp completion script.Mar 29 2023, 5:59 AM
Viacheslav changed the task status from Open to Needs testing.Mar 29 2023, 6:42 AM
Viacheslav assigned this task to indrajitr.
pasik subscribed.Mar 29 2023, 9:12 AM
Apachez subscribed.Aug 25 2023, 9:15 PM

The file list_ntp_servers.sh is nowhere to be found in VyOS 1.4-rolling-202308250021:

root@vyos:~# find / -iname "list_ntp_servers.sh"
find: File system loop detected; ‘/sys/kernel/debug/pinctrl’ is part of the same file system loop as ‘/sys/kernel/debug’.
root@vyos:~#

So I guess this can be put as resolved?

indrajitr closed this task as Resolved.Oct 13 2023, 10:08 PM

Implementation complete