Page MenuHomeVyOS Platform

IPoE-server named pool must not rely on the authentication type
Closed, ResolvedPublicBUG

Description

IPoE-server named pool and gateway must not rely on the authentication type

There is a bug in the template https://github.com/vyos/vyos-1x/blob/7f0eb0b029c927e4b7b0003c934f682be9b36380/data/templates/accel-ppp/ipoe.config.j2#L45-L51
It sets required values only for auth noauth, expected for any type of auth.

To reproduce

set service ipoe-server authentication mode 'radius'
set service ipoe-server authentication radius server 192.168.122.14 key 'vyos-secret'
set service ipoe-server client-ip-pool name POOL1 gateway-address '192.0.2.1'
set service ipoe-server client-ip-pool name POOL1 subnet '192.0.2.0/24'
set service ipoe-server interface eth1 vlan '2000-3000'

What we get:

[ipoe]
verbose=1
interface=re:^eth1\.(200\d|20[1-9]\d|2[1-9]\d{2}|3000)$,shared=1,mode=L2,ifcfg=1,start=dhcpv4,ipv6=1
vlan-mon=eth1,2000-3000
proxy-arp=1

What we expect:

[ipoe]
verbose=1
interface=re:^eth1\.(200\d|20[1-9]\d|2[1-9]\d{2}|3000)$,shared=1,mode=L2,ifcfg=1,start=dhcpv4,ipv6=1
vlan-mon=eth1,2000-3000
ip-pool=POOL1
gw-ip-address=192.0.2.1/24
proxy-arp=1

Details

Difficulty level
Easy (less than an hour)
Version
VyOS 1.4-rolling-202303120743
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)