Page MenuHomeVyOS Platform

IPoE server vlan-mon is not working
Closed, ResolvedPublicBUG

Description

Incorrect template for IPoE server doesn't handle vlan-mon section

set service ipoe-server authentication mode 'noauth'
set service ipoe-server interface eth1 client-subnet '100.64.24.0/24'
set service ipoe-server interface eth1 network 'vlan'
set service ipoe-server interface eth1 vlan '2000-3000'

What we get:

[ipoe]
verbose=1
interface=re:eth1\.\d+,shared=0,mode=L2,ifcfg=1,range=100.64.24.0/24,start=dhcpv4,ipv6=1
noauth=1
proxy-arp=1

What we expect (vlan-mon):

[ipoe]
verbose=1
interface=re:eth1\.\d+,shared=0,mode=L2,ifcfg=1,range=100.64.24.0/24,start=dhcpv4,ipv6=1
noauth=1
proxy-arp=1

vlan-mon=eth1,2000-3000

Details

Difficulty level
Normal (likely a few hours)
Version
VyOS 1.4-rolling-202303060908
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

Viacheslav changed the task status from Open to In progress.Mar 6 2023, 11:14 AM
Viacheslav claimed this task.

PR https://github.com/vyos/vyos-1x/pull/1869

vyos@r14# run show conf com | match ipoe
set service ipoe-server authentication mode 'noauth'
set service ipoe-server interface eth1 client-subnet '100.64.24.0/24'
set service ipoe-server interface eth1 network 'vlan'
set service ipoe-server interface eth1 vlan '2000-3000'
[edit]
vyos@r14#

Check config:

vyos@r14# cat /run/accel-pppd/ipoe.conf  | grep "\[ipoe" -A 7
[ipoe]
verbose=1
interface=re:eth1\.\d+,shared=0,mode=L2,ifcfg=1,range=100.64.24.0/24,start=dhcpv4,ipv6=1
noauth=1
proxy-arp=1

vlan-mon=eth1,2000-3000

[edit]
vyos@r14#

The second bug is interface Regex does not work
Get:

interface=re:eth1\.\d+

Expect:

interface=re:^eth1\.(200\d|20[1-9]\d|2[1-9]\d{2}|3000)$
Viacheslav changed the task status from In progress to Needs testing.Mar 6 2023, 2:51 PM
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.