Page MenuHomeVyOS Platform
Create Task
Maniphest T4998

pppoe username validation too restrictive (regression)
Closed, ResolvedPublicBUG
Actions

Description

Sometime between 1.4-rolling-202301210856 and 1.4-rolling-202302110748, VyOS has started rejecting PPPoE usernames containing a '.' character.

In the UK at least, convention amongst several ISPs is to use PPPoE usernames of the form [email protected].

[edit interfaces pppoe pppoe0]
malcolm@kylerhea# set authentication username "[email protected]"



  Username is limited to alphanumerical characters, -, _, #, and @ with a total lenght of 128
  Value validation failed
  Set failed

(the error message also contains a typo: "lenght"!)

Details

Version
1.4-rolling-202302110748
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

mas90 created this task.Feb 12 2023, 3:45 PM
Viacheslav changed the task status from Open to In progress.Feb 12 2023, 8:28 PM
Viacheslav assigned this task to c-po.
c-po mentioned this in rVYOSONEX945f27cd4c58: pppoe: wwan: T4998: fix username not accepting dot (.).Feb 12 2023, 8:28 PM
c-po closed this task as Resolved.Feb 12 2023, 8:28 PM
c-po triaged this task as Urgent! priority.
c-po edited a custom field.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
c-po mentioned this in rVYOSONEX9d8bcc8096ae: pppoe: wwan: T4998: fix typo in constraintErrorMessage.Feb 12 2023, 8:30 PM
c-po added a comment.Feb 12 2023, 8:30 PM

Sorry about the trouble - fixed in next rolling release.

Thank you for beeing brave and running bleeding edge software!!

c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.Apr 26 2023, 6:57 PM