Page MenuHomeVyOS Platform

vyos.ethtool: improve/fix driver name detection
Closed, ResolvedPublic

Description

The current way of looking up the driver name using the sysfs and more specifically the 'module' file, does not work if the driver is not a module.
If the driver is compiled into the kernel directly 'module' does not exist.

This issue is commonly seen when running custom kernels that include certain device drivers with =y instead of =m.
By leveraging the output of 'ethtool --driver <iface>' the driver can be reliably detected in these circumstances too.

Regression tested on x86 for igc and arm64 qemu virtio-net with CONFIG_VIRTIO_NET=y set.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Internal change (not visible to end users)

Revisions and Commits

Event Timeline

MartB changed the task status from Open to In progress.Jan 26 2023, 11:59 PM
MartB created this task.
MartB created this object in space S1 VyOS Public.
MartB added a commit: Restricted Diffusion Commit.Jan 27 2023, 12:16 AM
Viacheslav changed the task status from In progress to Needs testing.Jan 27 2023, 10:23 AM