Right now we have support for RADIUS rate-limit in all accel-ppp services except PPTP, even though there seems to be no reason to omit it. Since those options are now in a reusable XML, all we need to do is to include it in the PPTP interface definitions and extend the Jinja2 template.
Description
Description
Details
Details
- Difficulty level
- Unknown (require assessment)
- Version
- -
- Why the issue appeared?
- Will be filled on close
- Is it a breaking change?
- Perfectly compatible
- Issue type
- Improvement (missing useful functionality)
Related Objects
Related Objects
- Mentioned In
- 1.3.3
Event Timeline
Comment Actions
For 1.4 rate-limit in the wrong place
set vpn pptp remote-access authentication rate-limit
Expected in the radius section:
set vpn pptp remote-access authentication radius rate-limit
Comment Actions
PR for 1.3 https://github.com/vyos/vyos-1x/pull/1952
PR for 1.4 fix https://github.com/vyos/vyos-1x/pull/1953