Page MenuHomeVyOS Platform

Rename DPD action `hold` to `trap`
Closed, ResolvedPublicFEATURE REQUEST

Description

DPD action values are outdated.

vyos@vyos# set vpn ipsec ike-group IKE-HUB dead-peer-detection action
Possible completions:
   hold                 Attempt to re-negotiate the connection when matching traffic is seen
   clear                Remove the connection immediately
   restart              Attempt to re-negotiate the connection immediately

but in strongswan documentation
https://docs.strongswan.org/docs/5.9/swanctl/swanctlConf.html

child>.dpd_action

Action to perform for this CHILD_SA on DPD timeout. The default clear closes the CHILD_SA and does not take further action. trap installs a trap policy, which will catch matching traffic and tries to re-negotiate the tunnel on-demand (note that this is redundant if start_action includes trap. restart immediately tries to re-negotiate the CHILD_SA under a fresh IKE_SA.

Details

Version
VyOS 1.4-rolling-202208290458
Is it a breaking change?
Config syntax change (migratable)

Event Timeline

zsdc changed the subtype of this task from "Bug" to "Feature Request".Aug 30 2022, 12:40 PM
zsdc subscribed.

Not the bug, because it is internally translated to the proper value: https://github.com/vyos/vyos-1x/blob/b01f27b3bb3f4cbc6096011856d83009d0440313/data/templates/ipsec/swanctl/peer.j2#L90

But renaming hold to trap can be considered for a CLI improvement.

zsdc renamed this task from DPD action values are outdated to Rename DPD action `hold` to `trap`.Aug 30 2022, 12:40 PM
dmbaturin changed Is it a breaking change? from Perfectly compatible to Config syntax change (migratable).
dmbaturin changed Issue type from Bug (incorrect behavior) to improvement.

We've discussed this in the maintainer meeting and we agreed on migrating the hold CLI option to trap.

a.apostoliuk changed the task status from Open to In progress.Jan 16 2024, 12:54 PM
a.apostoliuk changed the task status from In progress to Needs testing.Jan 17 2024, 8:40 AM
a.apostoliuk closed this task as Resolved.
a.apostoliuk moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
a.apostoliuk moved this task from Open to Finished on the VyOS 1.5 Circinus board.