Page MenuHomeVyOS Platform
Create Task
Maniphest T4643

Smoketest exclude either sstp or openconnect from pki-misc default listen port
Closed, ResolvedPublicBUG
Actions

Description

Exclude either sstp or openconnect defaul listen port 443 from smoketest pki-misc
As both services can't start due, they try to bind the same port

Details

Version
VyOS 1.4-rolling-202208220217
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

Viacheslav created this task.Aug 25 2022, 6:44 AM
Viacheslav added a comment.Aug 25 2022, 7:08 AM

PR https://github.com/vyos/vyos-1x/pull/1495

Viacheslav changed the task status from Open to In progress.Aug 25 2022, 7:13 AM
Viacheslav claimed this task.
Restricted Repository Identity mentioned this in rVYOSONEX4f5f01f6a4f0: Merge pull request #1495 from sever-sever/T4643.Aug 25 2022, 4:54 PM
Viacheslav mentioned this in rVYOSONEXfa91f567b7b5: smoketest: T4643: Change openconnect default port.Aug 25 2022, 4:54 PM
Viacheslav closed this task as Resolved.Aug 25 2022, 5:07 PM
Viacheslav moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
Viacheslav reopened this task as Needs testing.Aug 26 2022, 8:46 AM
Viacheslav added a comment.Aug 26 2022, 11:02 AM

PR https://github.com/vyos/vyos-1x/pull/1499

Viacheslav added a comment.Aug 26 2022, 11:15 AM

Before fix:

06:04:21  DEBUG - FAIL: test_pki_misc (__main__.TestConfigPkiMisc)
06:04:21  DEBUG - ----------------------------------------------------------------------
06:04:21  DEBUG - Traceback (most recent call last):
06:04:21  DEBUG -   File "/usr/bin/vyos-configtest", line 50, in test_config_load
06:04:21  DEBUG -     self.session.commit()
06:04:21  DEBUG - vyos.configsession.ConfigSessionError: [[service https]] failed
06:04:21  DEBUG - Commit failed
06:04:21  DEBUG - 
06:04:21  DEBUG - 
06:04:21  DEBUG - During handling of the above exception, another exception occurred:
06:04:21  DEBUG - 
06:04:21  DEBUG - Traceback (most recent call last):
06:04:21  DEBUG -   File "/usr/bin/vyos-configtest", line 53, in test_config_load
06:04:21  DEBUG -     self.fail()
06:04:21  DEBUG - AssertionError: None

After fix:

vyos@r14:~$ /usr/bin/vyos-configtest
Generating tests
... completed: 0.000608
test_pki_misc (__main__.TestConfigPkiMisc) ...  time: 16.943
ok

----------------------------------------------------------------------
Ran 1 test in 16.952s

OK
vyos@r14:~$
Restricted Repository Identity mentioned this in rVYOSONEX22b6a3f52487: Merge pull request #1499 from sever-sever/T4643-smoketest.Aug 26 2022, 5:30 PM
Viacheslav mentioned this in rVYOSONEXc2fc87c02dd5: smoketest: T4643: Delete vpn sstp from config as we have HTTP.Aug 26 2022, 5:30 PM
c-po mentioned this in rVYOSONEXb15e550fe7d7: Revert "smoketest: T4643: Delete vpn sstp from config as we have HTTP".Aug 27 2022, 6:09 AM
c-po mentioned this in rVYOSONEX8458e9b0efeb: Revert "smoketest: T4643: Change openconnect default port".
c-po mentioned this in rVYOSONEX94a1728ae319: smoketest: T4643: create individual configs fot https service and sstp vpn.
c-po mentioned this in rVYOSONEXd42991a4c4ec: smoketest: T4643: bind sstp service to port 8443.Aug 28 2022, 6:41 AM
Viacheslav closed this task as Resolved.Aug 31 2022, 5:52 PM