UPnP does not work due to incorrect template
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	Viacheslav
	Aug 16 2022, 3:51 PM

Description

UPnP does not work due to incorrect template option names
VyOS configuration:

set service upnp listen '192.0.2.2'
set service upnp rule 10 action 'allow'
set service upnp rule 10 external-port-range '1024-65535'
set service upnp rule 10 internal-port-range '1024-65535'
set service upnp rule 10 ip '10.0.0.1'
set service upnp wan-interface 'eth0'
set service upnp  nat-pmp

In the template, we see rules instead of rule
If config.disable also incorrect option https://github.com/vyos/vyos-1x/blob/a21669ee5c87425a2eb91631eb00774b30249c8e/data/templates/firewall/upnpd.conf.j2#L146-L148

So generated /run/upnp/miniupnp.conf with rules doesn't work at all.

vyos@r1# commit
[ service upnp ]
{'listen': ['192.0.2.2'],
 'nat_pmp': {},
 'rule': {'10': {'action': 'allow',
                 'external_port_range': '1024-65535',
                 'internal_port_range': '1024-65535',
                 'ip': '10.0.0.1'}},
 'uuid': UUID('c7e987c2-1d7a-11ed-9e57-df03de3baf35'),
 'wan_interface': 'eth0'}

[edit]
vyos@r1#