Page MenuHomeVyOS Platform
Create Task
Maniphest T4290

BGP source-interface fails to commit
Closed, ResolvedPublicBUG
Actions

Description

When setting the BGP source-interface for a neighbor, the commit fails to start the BGP service. Below is the full error. I have a feeling this is no longer supported in v1.4 because the docs do not even list this as an option.

vyos@vyos# set neighbor eth2.2000 interface source-interface eth2.2000
[edit protocols bgp]
vyos@vyos# commit
[ protocols bgp ]
VyOS had an issue completing a command.

We are sorry that you encountered a problem while using VyOS.
There are a few things you can do to help us (and yourself):
- Contact us using the online help desk if you have a subscription:
  https://support.vyos.io/
- Make sure you are running the latest version of VyOS available at:
  https://vyos.net/get/
- Consult the community forum to see how to handle this issue:
  https://forum.vyos.io
- Join us on Slack where our users exchange help and advice:
  https://vyos.slack.com

When reporting problems, please include as much information as possible:
- do not obfuscate any data (feel free to contact us privately if your
  business policy requires it)
- and include all the information presented below

Report time:      2022-03-07 22:16:39
Image version:    VyOS 1.4-rolling-202202040318
Release train:    sagitta

Built by:         autobuild@vyos.net
Built on:         Fri 04 Feb 2022 03:18 UTC
Build UUID:       3099ad05-9578-4068-9b1a-caaa8a859f09
Build commit ID:  1d455e14a17f96

Architecture:     x86_64
Boot via:         installed image
System type:      KVM guest

Hardware vendor:  QEMU
Hardware model:   Standard PC (Q35 + ICH9, 2009)
Hardware S/N:
Hardware UUID:    3bfc4abf-a9ed-405c-b240-a351296c6add

Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/protocols_bgp.py", line 326, in <module>
    apply(c)
  File "/usr/libexec/vyos/conf_mode/protocols_bgp.py", line 317, in apply
    frr_cfg.commit_configuration(bgp_daemon)
  File "/usr/lib/python3/dist-packages/vyos/frr.py", line 480, in commit_configuration
    raise ConfigurationNotValid(f'Config commit retry counter ({count_max}) exceeded')
vyos.frr.ConfigurationNotValid: Config commit retry counter (5) exceeded



[[protocols bgp]] failed
Commit failed
[edit protocols bgp]

Details

Version
VyOS 1.4-rolling-202202040318
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

dcplaya created this task.Mar 8 2022, 6:29 AM
pasik subscribed.Mar 8 2022, 8:30 AM
Viacheslav subscribed.Mar 11 2022, 12:02 PM

Your configuration should be like:

set protocols bgp local-as '65001'
set protocols bgp neighbor eth0 interface peer-group 'PGROUP'
set protocols bgp peer-group PGROUP address-family ipv4-unicast
set protocols bgp peer-group PGROUP remote-as '65002'

op-mode:

yos@r16-roll:~$ show ip bgp sum

IPv4 Unicast Summary (VRF default):
BGP router identifier 100.64.2.16, local AS number 65001 vrf-id 0
BGP table version 1
RIB entries 1, using 184 bytes of memory
Peers 1, using 723 KiB of memory
Peer groups 1, using 64 bytes of memory

Neighbor        V         AS   MsgRcvd   MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd   PfxSnt Desc
eth0            4      65002         4         6        0    0    0 00:00:26            1        1 N/A

Total number of neighbors 1
dcplaya added a comment.Mar 11 2022, 2:02 PM

You are correct, my config is not correct.

But, it either shouldn't let me set the config with an incorrect parameter. Especially not let me set it, commit it, and then it crashing on commit and stopping the BGP service.
For me, this wasn't a huge deal since I was peering with local services, but this could cause tragic issues on more complicated or important networks.

Viacheslav changed the task status from Open to In progress.Mar 13 2022, 12:57 PM
Viacheslav claimed this task.
Viacheslav added a comment.Mar 13 2022, 1:01 PM

PR https://github.com/vyos/vyos-1x/pull/1248

c-po closed this task as Resolved.Mar 24 2022, 5:21 PM
Viacheslav mentioned this in rVYOSONEXa7a7e38049d4: bgp: T4290: Add verify source-interface for none ip neighbor.Mar 24 2022, 5:21 PM
Restricted Repository Identity mentioned this in rVYOSONEX3a85acc5fa90: Merge pull request #1248 from sever-sever/T4290.Mar 24 2022, 5:21 PM