Page MenuHomeVyOS Platform

Commit time for deleting sflow configuration ~1.5 min
Closed, ResolvedPublicBUG

Description

To reproduce add a delete sflow configuration in 1.4 (1.3 is not affected by this bug)

Set ip address + sflow config:

set interfaces ethernet eth1 address 203.0.113.24/24
commit

set system flow-accounting disable-imt
set system flow-accounting interface 'eth1'
set system flow-accounting sflow server 192.168.122.1 port '6343'
commit

Delete config:

vyos@vyos# delete system flow-accounting 
[edit]
vyos@vyos# time commit

real	1m27.036s
user	0m0.307s
sys	0m0.150s

`

Details

Difficulty level
Unknown (require assessment)
Version
VyOS 1.4-rolling-202112060318
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

It invokes systemd-tty-ask-password-agent which stalls the process termination:

root       17434  0.0  0.0  10068  3856 pts/0    S+   19:13   0:00  |                           \_ systemctl stop uacctd.service
root       17435  0.0  0.0  13108  2576 pts/0    S+   19:13   0:00  |                               \_ /bin/systemd-tty-ask-password-agent --watch

Strace statistics

Possibly it is not the main issue.
Also, we can see this delay with option no-ask-pass

systemctl --no-ask-password restart uacctd

Should be fixed in https://vyos.dev/T5232
needs to re-check

Viacheslav changed the task status from Open to Needs testing.Oct 27 2023, 7:36 AM
Viacheslav claimed this task.
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.