Page MenuHomeVyOS Platform

Wrong regex validation in XML definitions
Closed, ResolvedPublicBUG

Description

Regarding this regex, https://github.com/vyos/vyos-1x/blob/current/interface-definitions/dns-domain-name.xml.in#L36 should not be possible to define the hostname with some special characters "_+#" ...

set system host-name 213r+21_123-#
`

That means <regex> in XML definitions do not work

Details

Difficulty level
Easy (less than an hour)
Version
1.4-rolling-202112030318
Why the issue appeared?
Design mistake
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

Unknown Object (User) created this task.Dec 4 2021, 1:34 PM
c-po triaged this task as High priority.
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po changed Why the issue appeared? from Will be filled on close to Design mistake.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.