Maniphest T4045

Unable to "format disk <new> like <old>"
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	c-po
	Dec 4 2021, 6:32 AM

Tags

Referenced Files

None

Subscribers

Description

Commit https://github.com/vyos/vyos-1x/commit/deed5740137032f5512f21d167af9f362922c71d introduced the vyos.util.cmd() utility helper.
If an empty disk is formatted like an existing array disk, an error is thrown as the disk has no partition table. This makes cmd() fail as it raises an error if returncode != 0

Details

Version: 1.3.0-epa1
Is it a breaking change?: Perfectly compatible
Issue type: Bug (incorrect behavior)

Related Objects

Mentioned In: rVYOSONEXe87a1c836415: op-mode: disk: T4045: bugfix "format disk <new> like <old>"
rVYOSONEXe151c113e9e7: op-mode: disk: T4045: cleanup code to use python f'ormat strings
rVYOSONEX4207b4c26431: op-mode: disk: T4045: bugfix "format disk <new> like <old>"
rVYOSONEX467eb1f18ec9: op-mode: disk: T4045: cleanup code to use python f'ormat strings

Event Timeline

c-po created this task.Dec 4 2021, 6:32 AM

c-po mentioned this in rVYOSONEX467eb1f18ec9: op-mode: disk: T4045: cleanup code to use python f'ormat strings.Dec 4 2021, 6:38 AM

c-po mentioned this in rVYOSONEX4207b4c26431: op-mode: disk: T4045: bugfix "format disk <new> like <old>".

c-po mentioned this in rVYOSONEXe151c113e9e7: op-mode: disk: T4045: cleanup code to use python f'ormat strings.

c-po mentioned this in rVYOSONEXe87a1c836415: op-mode: disk: T4045: bugfix "format disk <new> like <old>".

c-po closed this task as Resolved.Dec 4 2021, 6:49 AM

c-po claimed this task.

c-po triaged this task as Normal priority.

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.

c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.

c-po edited a custom field.

pasik subscribed.Dec 4 2021, 11:33 AM