Page MenuHomeVyOS Platform
Create Task
Maniphest T4037

HTTP transfers do not follow redirects
Closed, ResolvedPublic
Actions

Description

add system image et al will happily download the redirect pages without following redirects.

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

erkin created this task.Dec 2 2021, 2:18 PM
erkin changed the task status from Open to In progress.
erkin triaged this task as Normal priority.
erkin mentioned this in rVYOSONEXe86edf18c180: remote: T4037: Follow HTTP redirects.Dec 2 2021, 2:30 PM
Restricted Repository Identity mentioned this in rVYOSONEX5a871f0dac02: Merge pull request #1092 from erkin/current.Dec 2 2021, 2:30 PM
c-po subscribed.Dec 4 2021, 4:04 PM
vyos@vyos:~$ add system image http://FQDN/vyos-1.4-rolling-202112010318-amd64.iso
Trying to fetch ISO file from http://FQDN/vyos-1.4-rolling-202112010318-amd64.iso...
Downloading...
Redirecting to http://FQDN/vyos-1.4-rolling-202112010318-amd64.iso
The file is 436.000 MiB.
[###__________________________________________________________________________________
c-po closed this task as Resolved.Dec 4 2021, 4:04 PM
c-po reopened this task as In progress.

Question is why it tells us: Redirecting to http://FQDN/ http and not https?

pasik subscribed.Dec 4 2021, 4:48 PM
c-po moved this task from Open to In Progress on the VyOS 1.4 Sagitta board.Dec 12 2021, 9:39 PM
Restricted Repository Identity mentioned this in rVYOSONEX95667607c9b3: Merge pull request #1107 from erkin/current.Dec 16 2021, 3:30 PM
erkin mentioned this in rVYOSONEXdc8c230ad45a: remote: T4037: Report the final URL when following redirects.Dec 16 2021, 3:30 PM
erkin closed this task as Resolved.Dec 16 2021, 4:19 PM

I assumed the last element of .history[] is the final URL, so I had it display .history[-1]; but it turns out it overwrites .url with the final destination and only keeps the previous redirects in .history[]. Now it just displays .url if .history[] is not empty.

c-po moved this task from In Progress to Finished on the VyOS 1.4 Sagitta board.Dec 26 2021, 10:08 AM