Maniphest T3850

Dots are no longer allowed in SSH public key names
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	dmbaturin
	Sep 23 2021, 1:49 PM

Tags

Referenced Files

None

Subscribers

Description

dmbaturin@reki# set system login user dmbaturin authentication public-keys [email protected] key AAAAE2VjZHNhLXNoYTItbmlzdHA1MjEAAAAIbmlzdHA1MjEAAACFBAGvM1Es7LbNUIV2dCP+CE+g2n4HIFquRfpnhBx8FqfFSmAm7IoR2vyfYI0rxX32+1rslRCfQnjlKh8tYaOUe9FPxAAWNJBLf5lqWrhArQ6Q8MlwIylwBrPD7bRplQ5rflZoahy0tnKCdUWLcmOe1LylNsrt1rrI40Fa5s169RXt0+GT3w==

  
  
  Invalid value
  Value validation failed
  Set failed

This will break login for all routers that use dots in key names, which is very likely with keys like [email protected].

Details

Version: 1.3.0-20210922
Is it a breaking change?: Perfectly compatible
Issue type: Bug (incorrect behavior)

Related Objects

Mentioned In: rVYOSONEXc0d5c2a5bc28: smoketest: T3850: use as complicated as possible public-key name
rVYOSONEX6187ce264a39: smoketest: T3850: use as complicated as possible public-key name
rVYOSONEX875086bac61e: T3850: Revert "login: T1948: add missing ssh-public key name regex"
rVYOSONEX46ecdd015185: T3850: Revert "login: T1948: add missing ssh-public key name regex"

Event Timeline

dmbaturin created this task.Sep 23 2021, 1:49 PM

dmbaturin triaged this task as Urgent! priority.

dmbaturin edited a custom field.

https://github.com/vyos/vyos-1x/commit/688f9810fde3947db66ff7e4c0ea21bf9708feec

https://github.com/vyos/vyos-1x/commit/514da738173696c70440c959b9d7ec9afd77fbae

c-po mentioned this in rVYOSONEX46ecdd015185: T3850: Revert "login: T1948: add missing ssh-public key name regex".Sep 23 2021, 2:14 PM

c-po mentioned this in rVYOSONEX875086bac61e: T3850: Revert "login: T1948: add missing ssh-public key name regex".

c-po closed this task as Resolved.Sep 23 2021, 2:14 PM

c-po claimed this task.

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0-epa1) board.

c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.

c-po edited a custom field.

c-po mentioned this in rVYOSONEX6187ce264a39: smoketest: T3850: use as complicated as possible public-key name.Sep 23 2021, 4:45 PM

c-po mentioned this in rVYOSONEXc0d5c2a5bc28: smoketest: T3850: use as complicated as possible public-key name.

Thanks!