Page MenuHomeVyOS Platform
Create Task
Maniphest T3741

[BGP] default no-ipv4-unicast - by default
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Hi team.

I would like to add a command by default , it is set protocols bgp parameters default no-ipv4-unicast when you want to configure bgp . I know the default behavior is enable the IPv4 unicast address family is announced to all neighbors , but it brings the following issues :

1-if you don't want to announce the ipv4 NLRI , you should apply it and reconfigure the neighbors .
2 -if the rules/route-map is not setting correctly , you can redistribute ipv4 prefix inside other NLRI(CPU-LOAD)
3- there many type the BGP NLRI (VPNv4 routes, VPNv6 routes signalling for multicast VPNs, FlowSpec information, ...),it would be a premature conclusion to assume that they using its BGP IPv4 session.
4- many vendors don't enable it by default (ipv4 announce)
example in FRR :

vyos# show running-config bgpd no-header
frr version 7.5.1-20201222-185-gb3f4ff1d9
frr defaults traditional
hostname vyos
service integrated-vtysh-config
!
router bgp 65001
 no bgp ebgp-requires-policy
 no bgp default ipv4-unicast
 no bgp network import-check

Details

Difficulty level
Normal (likely a few hours)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Config syntax change (migratable)
Issue type
Feature (new functionality)

Related Objects

Event Timeline

fernando created this task.Aug 11 2021, 7:02 PM
Viacheslav added a subscriber: Viacheslav.Aug 11 2021, 8:10 PM

Similar task T2315, also there is bug related T1976, etc.
It should be a migration script that determines ip/ipv6 neighbor and set neighbor to properly afi.
So there is one question, how to determine which afi we should to use if we see "peer-group" in configuration?
I don't think that we can implement it in 1.3 as it uses an old codebase.

pasik added a subscriber: pasik.Aug 11 2021, 8:47 PM
fernando added a comment.Aug 11 2021, 9:46 PM

Thanks for you comment ! it's good consider that options

c-po added a subscriber: c-po.Aug 12 2021, 7:04 AM

@Viacheslav, when we use a migrator we should enable the ipv4 afi for each and every ipv4 neighbor if its not configured explicitly. What do you think? If a peer group is configured for that neighbour, too - that will be no issue.

What you think?

Viacheslav added a comment.Aug 14 2021, 5:34 AM

@c-po It makes sense
Need to try.

c-po claimed this task.Sep 4 2021, 9:24 AM
c-po triaged this task as Normal priority.
c-po removed a project: VyOS 1.3 Equuleus.
c-po changed Difficulty level from Unknown (require assessment) to Normal (likely a few hours).
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Config syntax change (migratable).
c-po set Issue type to Feature (new functionality).
c-po closed this task as Resolved.Oct 5 2021, 5:45 PM
Viacheslav mentioned this in T4175: BGP configuration failed.Jan 13 2022, 9:18 AM