Maniphest T3488

Specifying an invalid "interface address" like dhcph leads to commit error
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	c-po
	Apr 20 2021, 2:39 PM

Tags

Referenced Files

	F1356876: image.png
	Apr 20 2021, 2:39 PM

	F1356880: image.png
	Apr 20 2021, 2:39 PM

Subscribers

Description

image.png (128×406 px, 9 KB)

image.png (1×1 px, 189 KB)

Details

Version: 1.3.0-rc3
Is it a breaking change?: Stricter validation

Related Objects

Mentioned In: rVYOSONEX2fe39c3f4d74: xml: T3488: when using regex one must use ^ and $ when checking string literals
rVYOSONEX85d0ae7b434a: xml: T3488: when using regex one must use ^ and $ when checking string literals
rVYOSONEX5119af40aac0: interfaces: T3488: harden regex for supplied address string
rVYOSONEXdd4c60c1c342: interfaces: T3488: harden regex for supplied address string

Event Timeline

c-po created this task.Apr 20 2021, 2:39 PM

c-po claimed this task.

c-po mentioned this in rVYOSONEXdd4c60c1c342: interfaces: T3488: harden regex for supplied address string.Apr 20 2021, 5:36 PM

c-po closed this task as Resolved.Apr 20 2021, 5:36 PM

c-po triaged this task as Low priority.

c-po edited a custom field.

c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Stricter validation.

c-po mentioned this in rVYOSONEX5119af40aac0: interfaces: T3488: harden regex for supplied address string.Apr 20 2021, 5:37 PM

c-po mentioned this in rVYOSONEX85d0ae7b434a: xml: T3488: when using regex one must use ^ and $ when checking string literals.Apr 20 2021, 7:03 PM

c-po mentioned this in rVYOSONEX2fe39c3f4d74: xml: T3488: when using regex one must use ^ and $ when checking string literals.Apr 20 2021, 7:14 PM

pasik subscribed.Apr 21 2021, 7:33 AM

c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.May 24 2021, 7:38 PM